Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Roger Quadros <rogerq@ti.com>
CC:     Pawel Laszczak <pawell@cadence.com>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rahul Kumar <kurahul@cadence.com>
Subject: Re: [PATCH v2] usb: cdns3: Rids of duplicate error message
Thread-Topic: [PATCH v2] usb: cdns3: Rids of duplicate error message
Thread-Index: AQHWoGM50wbXYw0KR0uXLh7D+U1lm6mTnxYAgAAxQYCAAAc7AIAAC0EA
Date:   Mon, 12 Oct 2020 12:18:59 +0000
Message-ID: <20201012121831.GA17965@b29397-desktop>
References: <20201012064256.8344-1-pawell@cadence.com>
 <e5ab2110-6bb0-ce06-be4f-010a030e307f@ti.com>
 <DM6PR07MB5529E8B3EC059F7DA43EEC25DD070@DM6PR07MB5529.namprd07.prod.outlook.com>
 <ab93c402-f721-d780-654b-7b74bc5b2ab1@ti.com>
In-Reply-To: <ab93c402-f721-d780-654b-7b74bc5b2ab1@ti.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <712824E1DD877042ADA5EA66AD44925E@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 950a87fc-d40c-4b53-eb31-08d86ea8ff87
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2020 12:18:59.2498
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WzCJ01IVWzjtxPr7CYcx/Lsdi8yAVFJzlnN09q17axOA+qqugXpUtvbv7MF3NQAx4AU+i2YRqC61pDwBcwp7Yg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7859
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-10-12 14:38:16, Roger Quadros wrote:
> Pawel,
>=20
> On 12/10/2020 14:12, Pawel Laszczak wrote:
> > Hi Roger,
> >=20
> > On 12/10/2020 09:42, Pawel Laszczak wrote:
> > > On failure, the platform_get_irq_byname prints an error message
> > > so, patch removes error message related to this function from
> > > core.c file.
> > >=20
> > > A change was suggested during reviewing CDNSP driver by Chunfeng Yun.
> > >=20
> > > Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> > > ---
> > > Changelog:
> > > v2
> > > - simplified code as sugested by Roger Quadros.
> > >=20
> > >    drivers/usb/cdns3/core.c | 10 +---------
> > >    1 file changed, 1 insertion(+), 9 deletions(-)
> > >=20
> > > diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> > > index a0f73d4711ae..85ef3025b293 100644
> > > --- a/drivers/usb/cdns3/core.c
> > > +++ b/drivers/usb/cdns3/core.c
> > > @@ -469,22 +469,14 @@ static int cdns3_probe(struct platform_device *=
pdev)
> > >    	if (cdns->dev_irq =3D=3D -EPROBE_DEFER)
> >=20
> > Shouldn't this be
> > 	if (cdns->dev_irq < 0)
> > ?
> >=20
> > No, such line will change the original behavior of driver.
> >=20
> > Current patch allows to run driver when we support only host.
> > In such case the dev_irq can be < 0 and we still can use host  side.
>=20
> In that case should we check if we need dev_irq and if so then error out.
> i.e. if mode is "peripheral" or "otg"
>=20
> Also DT binding document says all 3 IRQs are mandatory. Do we need to upd=
ate that?
>=20

I agree with Roger, or you change the driver behaviour that return error
if the dev_irq is < 0.

Peter
>=20
> >=20
> > Regards,
> > Pawel Laszczak
> >=20
> > >    		return cdns->dev_irq;
> > > -	if (cdns->dev_irq < 0)
> > > -		dev_err(dev, "couldn't get peripheral irq\n");
> > > -
> > >    	regs =3D devm_platform_ioremap_resource_byname(pdev, "dev");
> > >    	if (IS_ERR(regs))
> > >    		return PTR_ERR(regs);
> > >    	cdns->dev_regs	=3D regs;
> > >    	cdns->otg_irq =3D platform_get_irq_byname(pdev, "otg");
> > > -	if (cdns->otg_irq =3D=3D -EPROBE_DEFER)
> > > -		return cdns->otg_irq;
> > > -
> > > -	if (cdns->otg_irq < 0) {
> > > -		dev_err(dev, "couldn't get otg irq\n");
> > > +	if (cdns->otg_irq < 0)
> > >    		return cdns->otg_irq;
> > > -	}
> > >    	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "otg")=
;
> > >    	if (!res) {
> > >=20
> >=20
>=20
> --=20
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

--=20

Thanks,
Peter Chen=