Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@nxp.com>, Roger Quadros <rogerq@ti.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v2] usb: cdns3: Rids of duplicate error message
Thread-Topic: [PATCH v2] usb: cdns3: Rids of duplicate error message
Thread-Index: AQHWoGM1FxWyT46v30e8Ja/DW+/1b6mTnxYAgAAk0ICAABOtAIAAC2CAgAABFhA=
Date:   Mon, 12 Oct 2020 12:26:46 +0000
Message-ID: <DM6PR07MB552936CAFDDD55189FCCA37DDD070@DM6PR07MB5529.namprd07.prod.outlook.com>
References: <20201012064256.8344-1-pawell@cadence.com>
 <e5ab2110-6bb0-ce06-be4f-010a030e307f@ti.com>
 <DM6PR07MB5529E8B3EC059F7DA43EEC25DD070@DM6PR07MB5529.namprd07.prod.outlook.com>
 <ab93c402-f721-d780-654b-7b74bc5b2ab1@ti.com>
 <20201012121831.GA17965@b29397-desktop>
In-Reply-To: <20201012121831.GA17965@b29397-desktop>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f41d6b5-bb2c-4168-c900-08d86eaa15ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2020 12:26:46.3222
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wxkemUmgIjGaUyhXvuaAzoTTVhBnOU0B3iXPkc3MLaWhhe4w7UfGMxTmq1hhoO0sbDsNs+vKoSwRPQvdNAVbbdPEV1ripz/KByRx5D8NbiQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5964
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-10-12_09:2020-10-12,2020-10-12 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 suspectscore=0
 phishscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0
 priorityscore=1501 mlxlogscore=999 clxscore=1015 spamscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2010120102
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>
>On 20-10-12 14:38:16, Roger Quadros wrote:
>> Pawel,
>>
>> On 12/10/2020 14:12, Pawel Laszczak wrote:
>> > Hi Roger,
>> >
>> > On 12/10/2020 09:42, Pawel Laszczak wrote:
>> > > On failure, the platform_get_irq_byname prints an error message
>> > > so, patch removes error message related to this function from
>> > > core.c file.
>> > >
>> > > A change was suggested during reviewing CDNSP driver by Chunfeng Yun=
.
>> > >
>> > > Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> > > ---
>> > > Changelog:
>> > > v2
>> > > - simplified code as sugested by Roger Quadros.
>> > >
>> > >    drivers/usb/cdns3/core.c | 10 +---------
>> > >    1 file changed, 1 insertion(+), 9 deletions(-)
>> > >
>> > > diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
>> > > index a0f73d4711ae..85ef3025b293 100644
>> > > --- a/drivers/usb/cdns3/core.c
>> > > +++ b/drivers/usb/cdns3/core.c
>> > > @@ -469,22 +469,14 @@ static int cdns3_probe(struct platform_device =
*pdev)
>> > >    	if (cdns->dev_irq =3D=3D -EPROBE_DEFER)
>> >
>> > Shouldn't this be
>> > 	if (cdns->dev_irq < 0)
>> > ?
>> >
>> > No, such line will change the original behavior of driver.
>> >
>> > Current patch allows to run driver when we support only host.
>> > In such case the dev_irq can be < 0 and we still can use host  side.
>>
>> In that case should we check if we need dev_irq and if so then error out=
.
>> i.e. if mode is "peripheral" or "otg"
>>
>> Also DT binding document says all 3 IRQs are mandatory. Do we need to up=
date that?
>>
>
>I agree with Roger, or you change the driver behaviour that return error
>if the dev_irq is < 0.

Ok, I will  change the  condition as suggested by Roger.=20

Pawel
>
>Peter
>>
>> >
>> > Regards,
>> > Pawel Laszczak
>> >
>> > >    		return cdns->dev_irq;
>> > > -	if (cdns->dev_irq < 0)
>> > > -		dev_err(dev, "couldn't get peripheral irq\n");
>> > > -
>> > >    	regs =3D devm_platform_ioremap_resource_byname(pdev, "dev");
>> > >    	if (IS_ERR(regs))
>> > >    		return PTR_ERR(regs);
>> > >    	cdns->dev_regs	=3D regs;
>> > >    	cdns->otg_irq =3D platform_get_irq_byname(pdev, "otg");
>> > > -	if (cdns->otg_irq =3D=3D -EPROBE_DEFER)
>> > > -		return cdns->otg_irq;
>> > > -
>> > > -	if (cdns->otg_irq < 0) {
>> > > -		dev_err(dev, "couldn't get otg irq\n");
>> > > +	if (cdns->otg_irq < 0)
>> > >    		return cdns->otg_irq;
>> > > -	}
>> > >    	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "otg"=
);
>> > >    	if (!res) {
>> > >
>> >
>>
>> --
>> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
>> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
>--
>
>Thanks,
>Peter Chen