Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] usb: cdns3: Variable 'length' set but not used
To:     Pawel Laszczak <pawell@cadence.com>, <balbi@kernel.org>
CC:     <peter.chen@nxp.com>, <nsekhar@ti.com>,
        <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kurahul@cadence.com>
References: <20201012064548.8725-1-pawell@cadence.com>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <902c4a1b-a5f1-b0ed-b2d6-af5c2893fee2@ti.com>
Date:   Mon, 12 Oct 2020 11:16:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201012064548.8725-1-pawell@cadence.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/10/2020 09:45, Pawel Laszczak wrote:
> Patch removes not used variable 'length' from
> cdns3_wa2_descmiss_copy_data function.
> 
> Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>

Acked-by: Roger Quadros <rogerq@ti.com>

> ---
> Changelog:
> v2
> - added "Fixes" tag.
> 
>   drivers/usb/cdns3/gadget.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 6e7b70a2e352..692acf7b9b14 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
>   
>   	while (!list_empty(&priv_ep->wa2_descmiss_req_list)) {
>   		int chunk_end;
> -		int length;
>   
>   		descmiss_priv_req =
>   			cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list);
> @@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
>   			break;
>   
>   		chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
> -		length = request->actual + descmiss_req->actual;
>   		request->status = descmiss_req->status;
>   		__cdns3_descmiss_copy_data(request, descmiss_req);
>   		list_del_init(&descmiss_priv_req->list);
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki