Message-ID: <44DAC892.7000100@cs.wisc.edu>
Date: Thu, 10 Aug 2006 01:48:02 -0400
From: Mike Christie <michaelc@cs.wisc.edu>
User-Agent: Thunderbird 1.5 (X11/20060313)
MIME-Version: 1.0
To: paulmck@us.ibm.com
CC: stelian@popies.net, linux-kernel@vger.kernel.org, akpm@osdl.org,
       paulus@au1.ibm.com, anton@au1.ibm.com, open-iscsi@googlegroups.com,
       pradeep@us.ibm.com, mashirle@us.ibm.com
Subject: Re: [PATCH] memory ordering in __kfifo primitives
References: <20060810001823.GA3026@us.ibm.com> <20060810003310.GA3071@us.ibm.com>
In-Reply-To: <20060810003310.GA3071@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1176
Lines: 25

Paul E. McKenney wrote:
> OK, it appears that we are even.  I forgot to attach the promised
> analysis of the callers to __kfifo_put() and __kfifo_get(), and
> the open-iscsi@googlegroups.com email address listed as maintainer
> in drivers/scsi/libiscsi.c bounces complaining that, as a non-member,
> I am not allowed to send it email.  ;-)

Sorry about that. I do not have any control over the email list. I will
change the maintainer info entry to indicate that users should just send
mail to me or linux-scsi.

> 
> Anyway, this time the analysis really is attached, sorry for my confusion!
> 

We have change the code a little since the analysis was made. But, it
does not really matter much now. I am fine with us just grabbing the
session lock or xmitmitex (I will send a patch and test it as well) if
your barrier patch is not accepted. We grab the session lock in the fast
path now so there is not much benefit left for us.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/