Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 12 Oct 2020 14:42:11 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Sascha Hauer <s.hauer@pengutronix.de>
Cc:     Christian Eggers <ceggers@arri.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Clark Wang <xiaoning.wang@nxp.com>
Subject: Re: [PATCH] spi: imx: Revert "spi: imx: enable runtime pm support"
Message-ID: <20201012134211.GE4332@sirena.org.uk>
References: <20201009042738.26602-1-ceggers@arri.de>
 <20201009073944.GA11648@pengutronix.de>
 <2670390.HS4A6M72fu@n95hx1g2>
 <20201012132821.GE11648@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="C94crkcyjafcjHxo"
Content-Disposition: inline
In-Reply-To: <20201012132821.GE11648@pengutronix.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--C94crkcyjafcjHxo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Oct 12, 2020 at 03:28:21PM +0200, Sascha Hauer wrote:
> On Mon, Oct 12, 2020 at 12:59:34PM +0200, Christian Eggers wrote:

> > What is the benefit of controlling the SPI clock with runtime PM instead of
> > doing it manually?

> The clocks are reconfigured less frequently with pm_runtime. Especially
> when enabling/disabling PLLs are involved pm_runtime can increase
> performance.

In particular pm_runtime has support for deferring the actual disable so
if you get lots of activity in quick succession you don't actually ever
disable things until the activity stops.  This can really help reduce
overhead.

--C94crkcyjafcjHxo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+EXTIACgkQJNaLcl1U
h9A2Igf/WNXC40I0lSAeUPBKRg2IXrUnfh2VeWaz5yiHlMmmwFIF9/ZtJWMTVQyx
fXXw3bDDp4zeFexvmfjRCa8hJcF2YCZQ03LH5iq0ME7oxZ48PFZephUgbrL5TZon
8gJeup8UsLcmuNd3gapzw3ZvlRpUWIMOpNJuq9sfkKy8I62eULIKPkNM9xAZ7jqA
T+kTdUrqi9WeiphNu32wFk0aDCn9xKGWTs3msPLDjJDdagbFd4woXbGWl0Hneuwi
wgiSMiHQ5z8JAGq8WNaGiaS+9hXQ45OSP9XfLv3FqAW/+vXVJHyLR3EAW9qDh2ra
vfCRe+uh3oLM+GCLoYwa6Nj0DRN34Q==
=snZ0
-----END PGP SIGNATURE-----

--C94crkcyjafcjHxo--