Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: rO4tLdlc35XpFS4ZFK0YbJ55cvfu2A7Chs4l+uKMpLKaIyvGv38Hq2wJGZ/MzJMOM03EeJdq0h
 8Rhr11GP11Ig==
IronPort-SDR: TTDIWA5/zh8RhdtXwCpiBYl8Dif6BuGBE75srLyiRrn52YU8NCg8b2YGIN7eXz6W8QuzTnA3GA
 WM3pfDC7wMWw==
Subject: Re: [PATCH v1 06/15] perf session: load data directory into tool
 process memory
To:     Andi Kleen <ak@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <810f3a69-0004-9dff-a911-b7ff97220ae0@linux.intel.com>
 <39cf6164-f3be-ae34-292a-94faef32fdb9@linux.intel.com>
 <20201012160921.GD466880@tassilo.jf.intel.com>
From:   Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <8f90c785-8bdc-e7cd-a6d9-7eed0fb2c6b3@linux.intel.com>
Date:   Mon, 12 Oct 2020 19:49:22 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <20201012160921.GD466880@tassilo.jf.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12.10.2020 19:09, Andi Kleen wrote:
> On Mon, Oct 12, 2020 at 11:58:58AM +0300, Alexey Budankov wrote:
>>
>> Read trace files located at data directory into tool process memory.
>> Basic analysis support of data directories is provided for report
>> mode. Raw dump (-D) and aggregated reports are available for data
>> directories, still with no memory consumption optimizations. However
>> data directories collected with --compression-level option enabled
>> can be analyzed with little less memory because trace files are
>> unmaped from tool process memory after loading collected data.
>> The implementation is based on the prototype [1], [2].
> 
> Should credit the author(s) of the prototypes.

Sure. Will explicitly add:
 
Suggested-by: Jiri Olsa <jolsa@kernel.org>
Suggested-by: Namhyung Kim <namhyung@kernel.org>

here and [PATCH v2 15/15], additionally to [1], [2] below.

Thanks for pointing this out!

>>
>> [1] git clone https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git -b perf/record_threads
>> [2] https://lore.kernel.org/lkml/20180913125450.21342-1-jolsa@kernel.org/
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>> ---
>>  tools/perf/util/session.c | 48 +++++++++++++++++++++++++++++++++++++++
>>  tools/perf/util/session.h |  1 +
>>  2 files changed, 49 insertions(+)
>>
>> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
>> index 6afc670fdf0c..0752eec19813 100644
>> --- a/tools/perf/util/session.c
>> +++ b/tools/perf/util/session.c
>> @@ -2212,6 +2212,17 @@ reader__process_events(struct reader *rd, struct perf_session *session,
>>  		goto more;
>>  
>>  out:
>> +	if (rd->unmap_file) {
>> +		int i;
>> +
>> +		for (i = 0; i < NUM_MMAPS; i++) {
>> +			if (mmaps[i]) {
>> +				munmap(mmaps[i], mmap_size);
>> +				mmaps[i] = NULL;
> 
> Okay so where is the mmap? Would make more sense to put that
> into the same patch as who adds the mmap. Or is the mmap
> code already in the perf source? In that case it should
> probably be some common helper with the existing users.

That mmap is already in the code. Agree, this part of the patch
can be applied prior the whole patch set.

Alexei