Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 12 Oct 2020 13:22:18 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: allwinner: beelink-gs1: Update LED power
 node
Message-ID: <20201012112218.juke4ll4dnwrmwzw@gilmour.lan>
References: <20201011212238.174792-1-peron.clem@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="4vrfdqaecy3uo5lg"
Content-Disposition: inline
In-Reply-To: <20201011212238.174792-1-peron.clem@gmail.com>
Precedence: bulk


--4vrfdqaecy3uo5lg
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

On Sun, Oct 11, 2020 at 11:22:37PM +0200, Cl=E9ment P=E9ron wrote:
> Beelink GS1 LED trigger a warning when running dtbs_check.
>=20
> Update the node with a valid pattern property.
>=20
> Also add the function and the color of the LED and drop the
> label which is deprecated.
>=20
> Signed-off-by: Cl=E9ment P=E9ron <peron.clem@gmail.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/ar=
ch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> index 3f7ceeb1a767..a364cb4e5b3f 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> @@ -7,6 +7,7 @@
>  #include "sun50i-h6-cpu-opp.dtsi"
> =20
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> =20
>  / {
>  	model =3D "Beelink GS1";
> @@ -43,8 +44,9 @@ ext_osc32k: ext_osc32k_clk {
>  	leds {
>  		compatible =3D "gpio-leds";
> =20
> -		power {
> -			label =3D "beelink:white:power";
> +		led-0 {
> +			function =3D LED_FUNCTION_POWER;
> +			color =3D <LED_COLOR_ID_WHITE>;
>  			gpios =3D <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
>  			default-state =3D "on";
>  		};

Doesn't that also change the sysfs file that LED is exposed to the userspac=
e with?

Maxime

--4vrfdqaecy3uo5lg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX4Q8agAKCRDj7w1vZxhR
xX7hAQC4oXWwgfacQSYBnPdjSjU2IAbgQDQSk9UPIxYpcwxv2QEAyhlxZbLdMBsT
26GqO5r09yx5qyIBCXe4HLluLHhijwk=
=+xcE
-----END PGP SIGNATURE-----

--4vrfdqaecy3uo5lg--