Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4298854pxu; Mon, 12 Oct 2020 15:23:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyY2OBlCR7L3Xhm/KfDmwm6YKgzFid5flmpxTR2fLcR27L241cphtHlhtaIQH0yaXkPh6AX X-Received: by 2002:a50:d0d0:: with SMTP id g16mr16492925edf.18.1602541418077; Mon, 12 Oct 2020 15:23:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602541418; cv=none; d=google.com; s=arc-20160816; b=nTE/JKhY9kEAa8XUAF2L39TmfAQiW/FZ4JTUw0JxcTjrC3hrph6QSzeWu/kHOYWBnl xU3yxJUPXMMhPEs1pwbcDSCi6KLPM1S3lhzVdYIJ0mYktqZDSzvRXJB5+/X6vGcFTVU+ 2K5xxPcmMjAHFlZ7WdZgKTwVB7AWAAC8/zLu1q296R9OaUb7U1FRB1eCq9iQnDdkthRu Genn0pZDnQI94A6bbc9di52shyjx9Kp/9yMN9M4JD/bmPtoZWWCVbPNyXa3Z7Wt/hK9M ZOsK6AiT9m7apmHJiXVBFoliJkvNziiKSs5kernOjDZ6vfKI/o4iwSrnOg2sJo0nfGE6 NrWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vkrttWY22PgoDVHwOPoIuNiCgEYgirYAvfMLVCZrx8c=; b=lO7uobtdFKkTqMPzlL6J1ieVnIbZPvJ/qaYcvkaanc4/nlO6BWVNKZFW9WhQt8j5mU GdyDxi8zQ9vZfN3GXcxpcm1ps+j11zSSpdwRzonApM8ycFk4qjvD+Ih90BVv4RjaMdfa mGCRSnClPW0Gx0BmzpiWQzJCkaNdh9XPUxuXB3wohHBshEn92D1cWHqwmm5euQ1NAOnA 3MXyxBnKDXRJ/J1QK0h8S+479Z/RZ7vFW97dcRKXSTZVctrhRa2xwC+0MmYPiHWbruVx cqQTsAS4j5ddxriFxyVkPBZ0mUu7kYFFu45GvhG62ig03bQ/hs53+3hPb2nuIcrwUZis WIqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MJAxLNaA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e13si13169586ejr.211.2020.10.12.15.23.15; Mon, 12 Oct 2020 15:23:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MJAxLNaA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731260AbgJLNiv (ORCPT + 99 others); Mon, 12 Oct 2020 09:38:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:40158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730344AbgJLNhP (ORCPT ); Mon, 12 Oct 2020 09:37:15 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D35E22203; Mon, 12 Oct 2020 13:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602509825; bh=xKk6bit8/CWUSLdRySUobvWcOHRDKm6MQA/zALFxt7s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MJAxLNaAVJDABMk8dLuQjq38IOqXOwyyhEedAlY1WFXoLdlV4ssd4IDyY76vzNodI CoDyoMKKZQob51SFF148MTU6IELrNIzc8EAdSEs7eWY0hhOt6DvkW2f1l6VGYS2Qgt K0nJPMHBIKbw7CyTWisFle2O3WARNMm6A7HzxxFU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Packham , Andrew Lunn , Linus Walleij , Sasha Levin Subject: [PATCH 4.14 18/70] pinctrl: mvebu: Fix i2c sda definition for 98DX3236 Date: Mon, 12 Oct 2020 15:26:34 +0200 Message-Id: <20201012132631.097694736@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012132630.201442517@linuxfoundation.org> References: <20201012132630.201442517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Packham [ Upstream commit 63c3212e7a37d68c89a13bdaebce869f4e064e67 ] Per the datasheet the i2c functions use MPP_Sel=0x1. They are documented as using MPP_Sel=0x4 as well but mixing 0x1 and 0x4 is clearly wrong. On the board tested 0x4 resulted in a non-functioning i2c bus so stick with 0x1 which works. Fixes: d7ae8f8dee7f ("pinctrl: mvebu: pinctrl driver for 98DX3236 SoC") Signed-off-by: Chris Packham Reviewed-by: Andrew Lunn Link: https://lore.kernel.org/r/20200907211712.9697-2-chris.packham@alliedtelesis.co.nz Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/mvebu/pinctrl-armada-xp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-xp.c b/drivers/pinctrl/mvebu/pinctrl-armada-xp.c index b854f1ee5de57..4ef3618bca93f 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-xp.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-xp.c @@ -418,7 +418,7 @@ static struct mvebu_mpp_mode mv98dx3236_mpp_modes[] = { MPP_VAR_FUNCTION(0x1, "i2c0", "sck", V_98DX3236_PLUS)), MPP_MODE(15, MPP_VAR_FUNCTION(0x0, "gpio", NULL, V_98DX3236_PLUS), - MPP_VAR_FUNCTION(0x4, "i2c0", "sda", V_98DX3236_PLUS)), + MPP_VAR_FUNCTION(0x1, "i2c0", "sda", V_98DX3236_PLUS)), MPP_MODE(16, MPP_VAR_FUNCTION(0x0, "gpo", NULL, V_98DX3236_PLUS), MPP_VAR_FUNCTION(0x4, "dev", "oe", V_98DX3236_PLUS)), -- 2.25.1