Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4341327pxu; Mon, 12 Oct 2020 16:51:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzycVtijFj+HyWKzfU3Ost77nYGGMnYeWGTf1t7eZJZOXvi22nsrus5tHD8euThy1Fk158X X-Received: by 2002:a50:c309:: with SMTP id a9mr17353175edb.199.1602546690951; Mon, 12 Oct 2020 16:51:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602546690; cv=none; d=google.com; s=arc-20160816; b=MrHpg9GZjI0EZ7iVkXnx1dVfsXy5XMWa7AwJ/as1CKUh79pMFp/MHJBH1iS7XUn3R7 cy/7zxA+Gg/xXnuXWVsOHn/8gfH/jaN8ibYOUtBS8BV3SL4SU0wtlZbpu/e3Wd4ndfVw 1e8EFYIRCoAMEFt7ggKkAWOwOM0E2ROTHbFAe8edZzGuNl3LcRakRoEwkQP7jDHuI6Rb 3cyC4xpSe0/vtdIIUx05Hyrk/w+EZnfz17W45EZAS+EdsOFW6vTbuIIp9sZthkv+rf3x F5uyXwCVNteXdHJgR5VJl4lMGscfhT5bMaLIQChxYT19lPwdVGysYMN2787h+jApi6SD k4hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=d3mtlV1yFPTHqt1BJKMF8iMQxi8EWxb/5d6CNSPMbTA=; b=b8FohLz1JCV55CMV7VXH8P7iYjyh/ez6mADVyzPmffVNQVa0o+r8bQd3YtI+SQIN6/ wSUR5X3s4j6KMwX8eRdAUpuPLTbZiANF6SSMcu8xwhMWelVCHDlJgDW333ffhoU6LicS xkaodBHArl1g4irDE1oVakeYwbk3OIC6i3Kj/HKw+gJ1uy6I5OZwKZT+pQ4HUiK72Ty+ 95NPNTI5h2XjcDp/1S3xzjx1gsJCZ63hB3sz5dFFbb59Qn2OLxpymeKrbM8WGeyqoM3o JgUgy0dFr3p6geq0CO6y4ceG2eSNQDIOeqRiVl3KYWQCu9uH4bMbSOcsCnWbZStijofa i9QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lnMgo8Az; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oc24si13681179ejb.530.2020.10.12.16.51.08; Mon, 12 Oct 2020 16:51:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lnMgo8Az; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731745AbgJLNrz (ORCPT + 99 others); Mon, 12 Oct 2020 09:47:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:46188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389769AbgJLNpz (ORCPT ); Mon, 12 Oct 2020 09:45:55 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1AFD208B8; Mon, 12 Oct 2020 13:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602510343; bh=tJmT2y/FrIAr0MGCssRr4tjanVeOY5jttuPUMfr1Ado=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lnMgo8AzlhTxO3SpBfjS2yPP7VP8ii9+XF10qs6lV+7nsF/DwtdmuQnrkgqh70JWd nLN7/3UUsdgUpk6M6ndjdSyEveR9LofsfyRGzzeau/QgG12o5xAXj2uUSMpVLi2ovq LM/WLFx/Cz71CMKPmy2qHjHkVVcaYdGV2orsnAEI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Necip Fazil Yildiran , Hans de Goede , mark gross , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.8 059/124] platform/x86: fix kconfig dependency warning for LG_LAPTOP Date: Mon, 12 Oct 2020 15:31:03 +0200 Message-Id: <20201012133149.717102975@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012133146.834528783@linuxfoundation.org> References: <20201012133146.834528783@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Necip Fazil Yildiran [ Upstream commit 8f0c01e666685c4d2e1a233e6f4d7ab16c9f8b2a ] When LG_LAPTOP is enabled and NEW_LEDS is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for LEDS_CLASS Depends on [n]: NEW_LEDS [=n] Selected by [y]: - LG_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && ACPI_WMI [=y] && INPUT [=y] The reason is that LG_LAPTOP selects LEDS_CLASS without depending on or selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS. Honor the kconfig menu hierarchy to remove kconfig dependency warnings. Fixes: dbf0c5a6b1f8 ("platform/x86: Add LG Gram laptop special features driver") Signed-off-by: Necip Fazil Yildiran Reviewed-by: Hans de Goede Acked-by: mark gross Signed-off-by: Andy Shevchenko Signed-off-by: Sasha Levin --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 0581a54cf562f..e1668a9538c8f 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1091,6 +1091,7 @@ config LG_LAPTOP depends on ACPI_WMI depends on INPUT select INPUT_SPARSEKMAP + select NEW_LEDS select LEDS_CLASS help This driver adds support for hotkeys as well as control of keyboard -- 2.25.1