Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4359340pxu; Mon, 12 Oct 2020 17:30:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZr7v9vaJO9RwcQAbA+NemoarKbQs5tbCOwUGVrrNjZwNtkp7mvERAjL0pcAfJ6cBTQ03F X-Received: by 2002:a17:906:ecf6:: with SMTP id qt22mr29945426ejb.386.1602549044283; Mon, 12 Oct 2020 17:30:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602549044; cv=none; d=google.com; s=arc-20160816; b=ifNcDOJ+eicGl1/2He6MLDTOS7ZD/gB4f0ghuNpv2ju7AhdgNuu4ayUn9/AUU1+CXM zP+W/wgDf2PDqBWczf3JytuqP4OPMVsiZu90EnxzIA3wLzUGyJCv8sBFOi6IQtl5Q04A 6iolqb2FdQik4QDa03KYfraWaG4qPNTwBgIRSXerr/C1Dg8xAlweq3plZSojlBYgwi6i +Nz+sROhM4Ck4/32b4qeltoXVsk21G2hu34ef25PcUxTiuKqwVZHwLJ47MJOLaA/xvHo xq8WY+/oRhgTWcproTcVZxu3nIo+1KFHejwbDznBjWWu7jq7TrHp30MX4Lxint1+WCVw LVRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TCnFXnCqBOraGLpm61tZZTEv6dvAN/WlNeHyEYumP7I=; b=mz67J9zXMYq8y+o1Np5GKIc+AkE2CwvqEWFKz6Xy5FLJAxYAwZ3UnhasgROiRAblHQ jQ4hNUxLFzdoXZsCPin92dGGMqwfNm7gVa4583wYPu01sR8bpCYmgSVU2FLykhOjn5ks c7Ng0Oicp/2eRVvIwG+pig1L9h6HMtRXcAvJMwclenJJ9hYxO/GqeN5g1IKC4CiYpMWO dag3lB88eYj44x9JSINwIFhE72lb8mgYBBrVCVQVpM41mHQWj5N1BQE10iVZMWE/ghKF h/1hx0wb3bgitp0WPQTQgdifCq5N8mNe1Y9bmF4EW/JXa0pDWkJM8nlSx24+WNq45wv6 ePpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="opR7/2tu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si13610344ejc.209.2020.10.12.17.30.05; Mon, 12 Oct 2020 17:30:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="opR7/2tu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731724AbgJLNrq (ORCPT + 99 others); Mon, 12 Oct 2020 09:47:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:46748 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389778AbgJLNpz (ORCPT ); Mon, 12 Oct 2020 09:45:55 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 390162065C; Mon, 12 Oct 2020 13:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602510345; bh=GfTTG4A8Vg0dX0x0/CB+t7rlm4Ve3NoM8R9oCK/eivk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=opR7/2tuEj9ITRhGFJLFCr+ZDO2k+v8A90tJGpJWzEJRrikSDPejROvMlj0Qq535l k3/owm80aULlbKOpeCwo6U0P0Sr0nbPyfXv2BdU529eFovazONRiYH+qNmswDhqo1M VZ4Vg//zjf67TQH/VuTs8bDgQLsaj/0wmDVT4Wtw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Necip Fazil Yildiran , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.8 060/124] platform/x86: fix kconfig dependency warning for FUJITSU_LAPTOP Date: Mon, 12 Oct 2020 15:31:04 +0200 Message-Id: <20201012133149.764792978@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012133146.834528783@linuxfoundation.org> References: <20201012133146.834528783@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Necip Fazil Yildiran [ Upstream commit afdd1ebb72051e8b6b83c4d7dc542a9be0e1352d ] When FUJITSU_LAPTOP is enabled and NEW_LEDS is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for LEDS_CLASS Depends on [n]: NEW_LEDS [=n] Selected by [y]: - FUJITSU_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || ACPI_VIDEO [=n]=n) The reason is that FUJITSU_LAPTOP selects LEDS_CLASS without depending on or selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS. Honor the kconfig menu hierarchy to remove kconfig dependency warnings. Reported-by: Hans de Goede Fixes: d89bcc83e709 ("platform/x86: fujitsu-laptop: select LEDS_CLASS") Signed-off-by: Necip Fazil Yildiran Signed-off-by: Andy Shevchenko Signed-off-by: Sasha Levin --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index e1668a9538c8f..a5ad36083b671 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -469,6 +469,7 @@ config FUJITSU_LAPTOP depends on BACKLIGHT_CLASS_DEVICE depends on ACPI_VIDEO || ACPI_VIDEO = n select INPUT_SPARSEKMAP + select NEW_LEDS select LEDS_CLASS help This is a driver for laptops built by Fujitsu: -- 2.25.1