Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4459458pxu; Mon, 12 Oct 2020 21:23:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4/lO0FwFGXPdkod1Oqn17jchvCJca1q63RlOVP8WafYJzB9gB+zPugJndzcG2OONzhPP2 X-Received: by 2002:a17:906:5618:: with SMTP id f24mr30671588ejq.86.1602562983850; Mon, 12 Oct 2020 21:23:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602562983; cv=none; d=google.com; s=arc-20160816; b=kx1TOgMkdTAH2+J2GGdE9KkLf3XXlnIRlSn+px2VI6LQ4txYHbgy2B2eoAMxs3PXIB TIQmUtix0ZmWJ9gBj05m9ajq6JLya2akz7O35AA9ShwuYsNHNVLKepQqFVPvtAVISU7e 3OzV5DTlKiDCeSuelN47JyT/B4MMpAJshiq7fAvnZN0eXQl93qQalmDmXFtL6gh8ejmK krfPfgAYCg8YnnvVlNqiEdfQ8jrfnzISBn78xF4RT/Jczj7LoAurX/NaLh4un+eE9/Wq UmApduBAU4N6MN9H3CZx0Blh8s90LXUFuWTnRCOx+K3msYmdYfwVm77rfSZGDqS+Cd1q YwZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=KXjyEZ75Pe4z4wSYrGbLTLW5aWcGXSPk3cloYXZRaQ4=; b=LBgtoKqPK5jQHu0s0YCqJJIqmPl4njWFBxCEWKIkc61W/sdZKOv2VsPpmNB4LySExD jb0uwwG35hBXHT7vPZ4mXEtuy4srG7OqRi+D9HmyFKx1NQighsvgKhXQKdJ2tB00qs8E x2rUzaXLDa4U5CuYaZ6C0T7a29E8RIZP4+YRfyz8ebfSudgqjZQcfdMqOd1i9N6mL3b8 GW1sHP9XdwDjLGqklKCS6ZiM70L4aOh4wVxkCOCQHvwza8j4ZgkcnRn68rzrYv6YrKL/ KZ42Cn3lVIAGIVg4oIiQIxf6imHROVd1nANghC+nHHrhzJ1amhKfAE0I5U7qyjR9Qzet 33BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="rDqNIIj/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pg3si15968649ejb.94.2020.10.12.21.22.41; Mon, 12 Oct 2020 21:23:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="rDqNIIj/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389612AbgJLOYq (ORCPT + 99 others); Mon, 12 Oct 2020 10:24:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389328AbgJLOYp (ORCPT ); Mon, 12 Oct 2020 10:24:45 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C3AFC0613D0 for ; Mon, 12 Oct 2020 07:24:45 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id b2so16132643ilr.1 for ; Mon, 12 Oct 2020 07:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KXjyEZ75Pe4z4wSYrGbLTLW5aWcGXSPk3cloYXZRaQ4=; b=rDqNIIj/4RCVrCTL8/M7nsY1rbeEAMaUOaH858YqkKmjLup7HNaJas+bWUE8scDgMY WRgvGnWGk9gwIlxRrR1MKsaI1xyQbLtdsyiTaBFxunHI6UD73d/WqpJlABKqG9B8R1GX yttwsR7L2CXJ6PmPLUUCC3VNQ3704dbZ+fRx+ZpTJjhIKHGAvPOeKJ+nemH8b8zWVnYm AxPjX3mq06Z731A5VzfA2BLMaHqLrtUibfXqQtf32Zh1c7YkNJ/tEApnlk3dfDlTQ82l vIiwKheyCCeFVuWiON8Gq9fRnzlG8AziqZW4w/LBoSgyTcVHf6bAm63v6uoixd2JZxSZ 75kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KXjyEZ75Pe4z4wSYrGbLTLW5aWcGXSPk3cloYXZRaQ4=; b=sOB+fAe50XUsXPfYd+sGezF68iiC18iu2xq5ibMhd8uw0HxBQYlbRCWEYeizJMSpyL Bv8ZetUepJEveoM+UqSSIjCMOLqJFR3OfjZKnSKDRbmY2f/S0fQQvkOneqFbYBHNagVs ehWWOi+07chV42RRgsVrAkVzgzToUFsTAwBZwDCQXFMpT8/T2lur7jlYSKcFnrwHZl7V m8IaGiNnvpOlWfukSoDsvOc3uhlnWwqY+fnKJp/fUNX+u2suKPenLQQiptmzw3pR4FPq beW4nzYt7cpg73kEq28sdlC9Qy708szdG0lBCV7vll1VUZEcFpkK1YJpGSSPMkO9vXA0 +UDA== X-Gm-Message-State: AOAM531MnfeNl+l0+Tx6J1u0uMXuC5k53lQsfZgKryJOE8kqW+YTKZQm FlGzLWTTh1b2hyvnbIbvFTDKu1EI4oH6uQ== X-Received: by 2002:a92:ae0a:: with SMTP id s10mr19507476ilh.289.1602512683984; Mon, 12 Oct 2020 07:24:43 -0700 (PDT) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id c2sm7405690ioc.29.2020.10.12.07.24.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Oct 2020 07:24:43 -0700 (PDT) Subject: Re: [PATCH][next] io_uring: Fix sizeof() mismatch To: Colin King , Alexander Viro , Pavel Begunkov , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201012140341.77412-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <871e585c-06ca-17cb-f082-fec576bb75e1@kernel.dk> Date: Mon, 12 Oct 2020 08:24:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201012140341.77412-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/20 8:03 AM, Colin King wrote: > From: Colin Ian King > > An incorrect sizeof() is being used, sizeof(file_data->table) is not > correct, it should be sizeof(*file_data->table). Thanks, should be a no-op, which is why KASAN didn't complain in my testing. I'll queue this up, thanks. -- Jens Axboe