Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4534300pxu; Tue, 13 Oct 2020 00:10:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxo79ZvJs6HKxm0Qav+mWXbx9LLZEI+zuFJuWpE2LRnVJCcu9oqY5TmGvW1HO5T1v1kShxH X-Received: by 2002:aa7:c1d7:: with SMTP id d23mr18091263edp.205.1602573015877; Tue, 13 Oct 2020 00:10:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602573015; cv=none; d=google.com; s=arc-20160816; b=DRjrfV4/lyRusH3JKfQ7eTuDZIvtrZDK//I1NoauzGKbz6GVrwl91DYbg6QHFhJD5T 1EF9U9o/4in/Y4AqmUKRo9IkvyKprGx4DGFJbQDAwz1PhVdOUf6O6HmlBPzGGxs9HJeh K/XSdpEU806N2Na/YDnOxDR0xe41ZaD8Gnni91FwL0IaGz0YNaUYTsOLOQ88ZFu7XccP sG/UUlo5iuTspU3RwyID3i2JQ32CXtQQmEmfVLNwebxxR+zPdxaEITv0e2hoog4GLJKb NCrzRlpQCRxEbBiYh/iqGmzn/raIBdgqEfzsIfYEqoLnaNJgaXqTXQjY/j9PIEp0oaZd 3Uag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=7RGHV/MGxmBG8EBkmEPoZIhEVilmUpI/XTEm6ZxdNXc=; b=LR2Hdfl8YdFv9qG0G0O2Pz6WV4t2W8weoOnut1f2OjaoTOCln7LRcK+WBe1fHymPM8 kS92AGpO+l6lQp63699Rq6g5k/g5JPJ/7Y0lsTB/YmOCG+IfmaBh8yU0A2h1EQa8YG/y PkJ0JMwkMvX8NNXW51yCUZbUIhMeRBZK42PTXz2gxIYtBgQ8BIZwSGGKzemYZ9eiWfru jRRHf2nuKLbp/qkjNk+ah3qvs+Uhe+Yn4H4mU5QSPEaGWCEF+ntnrOEIEcpGGghkfV+w OoyYPZNdhzFFSU7bIKg1dWf+RHyZpmvf+7TfuIuy4s3h8gVYK9IraB7ePO4BBWIUoZC/ LimQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x4si1129284edq.65.2020.10.13.00.09.52; Tue, 13 Oct 2020 00:10:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390066AbgJLQBv (ORCPT + 99 others); Mon, 12 Oct 2020 12:01:51 -0400 Received: from mga11.intel.com ([192.55.52.93]:59729 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389562AbgJLQBv (ORCPT ); Mon, 12 Oct 2020 12:01:51 -0400 IronPort-SDR: uAj1jFW6sx1q/C7flGeGNjSIwh37YbyS3DEapkf/wIIZgIRA81oNSYGZ+kc+fzI8LvsI/xa921 tdnBMCefdg/w== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="162294887" X-IronPort-AV: E=Sophos;i="5.77,367,1596524400"; d="scan'208";a="162294887" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 09:01:50 -0700 IronPort-SDR: i3U8DHjXh/yBEJFOCr5LqII2KTjE24KOAFjbSVcqwBuULDFxKnHJtSf1zU97ffz0AQiK3v387Z h2RNmFWjsG8A== X-IronPort-AV: E=Sophos;i="5.77,367,1596524400"; d="scan'208";a="520734047" Received: from tassilo.jf.intel.com ([10.54.74.11]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 09:01:49 -0700 Date: Mon, 12 Oct 2020 09:01:44 -0700 From: Andi Kleen To: Alexey Budankov Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Alexander Shishkin , Adrian Hunter , Peter Zijlstra , Ingo Molnar , linux-kernel Subject: Re: [PATCH v1 02/15] perf report: output trace file name in raw trace dump Message-ID: <20201012160144.GA466880@tassilo.jf.intel.com> References: <810f3a69-0004-9dff-a911-b7ff97220ae0@linux.intel.com> <87e2050b-37e6-8ed8-e1e0-cfa074b030fa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87e2050b-37e6-8ed8-e1e0-cfa074b030fa@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 11:54:24AM +0300, Alexey Budankov wrote: > @@ -180,7 +183,8 @@ static int ordered_events__deliver_event(struct ordered_events *oe, > ordered_events); > > return perf_session__deliver_event(session, event->event, > - session->tool, event->file_offset); > + session->tool, event->file_offset, > + event->file_path); Wouldn't it be better to pass "event" around now, which would contain at least four of the arguments. These functions are getting entirely too many arguments. -Andi