Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 12 Oct 2020 22:03:24 +0200
From:   =?utf-8?Q?Ond=C5=99ej?= Jirman <megous@megous.com>
To:     Michal =?utf-8?B?U3VjaMOhbmVr?= <msuchanek@suse.de>
Cc:     Maxime Ripard <maxime@cerno.tech>,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Corentin Labbe <clabbe@baylibre.com>,
        Stefan Mavrodiev <stefan@olimex.com>,
        Icenowy Zheng <icenowy@aosc.io>,
        Georgii Staroselskii <georgii.staroselskii@emlid.com>,
        Bastian Germann <bage@linutronix.de>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: arm: sunxi: Fix Orange Pi Zero bindings
Message-ID: <20201012200324.yua77qwqbgfh42z7@core.my.home>
Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman <megous@megous.com>,
        Michal =?utf-8?B?U3VjaMOhbmVr?= <msuchanek@suse.de>,
        Maxime Ripard <maxime@cerno.tech>,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Corentin Labbe <clabbe@baylibre.com>,
        Stefan Mavrodiev <stefan@olimex.com>,
        Icenowy Zheng <icenowy@aosc.io>,
        Georgii Staroselskii <georgii.staroselskii@emlid.com>,
        Bastian Germann <bage@linutronix.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <59f7b5c566825838bbb62b778e05c514fe355e74.1602182270.git.msuchanek@suse.de>
 <e657976d8bb1bb627c983321fe9c61de5bc003b7.1602182270.git.msuchanek@suse.de>
 <20201012144753.mdxdacp7ctxxhhl2@gilmour.lan>
 <20201012180402.GT29778@kitsune.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201012180402.GT29778@kitsune.suse.cz>
Precedence: bulk

Hello Michal,

On Mon, Oct 12, 2020 at 08:04:02PM +0200, Michal Such?nek wrote:
> On Mon, Oct 12, 2020 at 04:47:53PM +0200, Maxime Ripard wrote:
> > On Thu, Oct 08, 2020 at 08:40:06PM +0200, Michal Suchanek wrote:
> > > There are two models of Orange Pi zero which are confusingly marketed
> > > under the same name. Old model comes without a flash memory and current
> > > model does have a flash memory. Add bindings for each model.
> > > 
> > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > 
> > Unfortunately, changing a compatible or a DT filename is not an option
> 
> So how do you handle the situation when you find out that there are two
> different devices marketed under the same name?
> 
> Surely the device tree is labaled by the device name but now you need
> two device trees that describe the two devices.

You can for example make the new DT name *-flash.dts, instead
of changing the name of existing DT to *-noflash.dts. Or if there's
a version number on the PCB that differs from the older variant,
use that version to differentiate the newer board DT.

regards,
	o.

> Thanks
> 
> Michal