From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <76306.1226@compuserve.com>
Subject: Re: [patch] i386: annotate the rest of entry.s::nmi
Date: Thu, 10 Aug 2006 14:58:45 +0200
User-Agent: KMail/1.9.3
Cc: "Jan Beulich" <jbeulich@novell.com>, linux-kernel@vger.kernel.org,
       stsp@aknet.ru
References: <200608100851_MC3-1-C7A8-8B6A@compuserve.com>
In-Reply-To: <200608100851_MC3-1-C7A8-8B6A@compuserve.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200608101458.45683.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1078
Lines: 26

On Thursday 10 August 2006 14:48, Chuck Ebbert wrote:
> In-Reply-To: <44DB0927.76E4.0078.0@novell.com>
> 
> On Thu, 10 Aug 2006 10:23:35 +0200, Jan Beulich wrote:
> 
> > >Part of the NMI handler is missing annotations.  Just moving
> > >the RING0_INT_FRAME macro fixes it.  And additional comments
> > >should warn anyone changing this to recheck the annotations.
> > 
> > I have to admit that I can't see the value of this movement; the
> > code sequence in question was left un-annotated intentionally.
> > The point is that the push-es in FIX_STACK() aren't annotated, so
> > things won't be correct at those points anyway.
> 
> I have a patch here that adds that, but it won't compile
> because that part of the NMI handler is un-annotated:

Ok i dropped the original patch for now and you guys can work
out a correct fix.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/