Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] xfs: fix Kconfig asking about XFS_SUPPORT_V4 when
 XFS_FS=n
To:     "Darrick J. Wong" <darrick.wong@oracle.com>,
        Pavel Machek <pavel@ucw.cz>, xfs <linux-xfs@vger.kernel.org>
Cc:     kernel list <linux-kernel@vger.kernel.org>, dchinner@redhat.com,
        sandeen@redhat.com
References: <20201012211157.GE6559@magnolia>
From:   Eric Sandeen <sandeen@sandeen.net>
Message-ID: <4354fb15-9aa0-0957-eea8-89a930774d40@sandeen.net>
Date:   Mon, 12 Oct 2020 16:23:32 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <20201012211157.GE6559@magnolia>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/12/20 4:11 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Pavel Machek complained that the question about supporting deprecated
> XFS v4 comes up even when XFS is disabled.  This clearly makes no sense,
> so fix Kconfig.
> 
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  fs/xfs/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index 5422227e9e93..9fac5ea8d0e4 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -24,6 +24,7 @@ config XFS_FS
>  
>  config XFS_SUPPORT_V4
>  	bool "Support deprecated V4 (crc=0) format"
> +	depends on XFS_FS
>  	default y
>  	help
>  	  The V4 filesystem format lacks certain features that are supported
>