Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201012101012.GD25311@zn.tnic> <CAHk-=wiwBYoAKQ6H=n0ppZfMe6nVDwDw6cruv7jxZZw4XEmUsg@mail.gmail.com>
 <c8cfb3d2-d3c4-6d8d-1dfd-aeb349e26303@hpe.com> <20201012212709.GM25311@zn.tnic>
 <f778b25e-68e7-98ec-9032-b35696948405@hpe.com>
In-Reply-To: <f778b25e-68e7-98ec-9032-b35696948405@hpe.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 12 Oct 2020 14:46:10 -0700
Message-ID: <CAHk-=wg6MBLPzRrRYGQ6EeoUGV+-MdMraFiUiiQyenVk=t6=Bw@mail.gmail.com>
Subject: Re: [GIT PULL] x86/platform updates for v5.10
To:     Mike Travis <mike.travis@hpe.com>
Cc:     Borislav Petkov <bp@suse.de>, x86-ml <x86@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 12, 2020 at 2:42 PM Mike Travis <mike.travis@hpe.com> wrote:
>
> It should have been an unsigned long instead of an int as Linus
> suggested.  I'm not sure it's a write only variable as I think the mask
> is used to check if the interrupt occurred (I'll have to look closer).

At least "git grep" only shows two assignments to it.

Of course, that would miss any cases that play games with preprocessor
token pasting etc, so it's not entirely meaningful, but it's certainly
a hint..

And yes, I expect that the fix is to just make it "unsigned long", but
if it truly isn't actually used, maybe removal is better.

             Linus