Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 7qKY9lxU+5mmGRztc/7/18CEr+wqvYRCi5oO8DXPpqXLT7tmxX0cvMDhm904/qr9+ttWkCv8Jq
 FEXLv6CCR12Q==
IronPort-SDR: jEnIP4wB77BIL1VjPSes2BsTJLTkvxBfedty6Z5NB+2nNstxTVSM8M6uUrI3hWGpHok6KlTaY9
 2pzDAXWEyIeQ==
Date:   Tue, 13 Oct 2020 07:01:18 +0800
From:   Philip Li <philip.li@intel.com>
To:     Thomas Pedersen <thomas@adapt-ip.com>
Cc:     kernel test robot <rong.a.chen@intel.com>,
        Johannes Berg <johannes.berg@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, lkp@lists.01.org,
        lkp@intel.com
Subject: Re: [mac80211_hwsim] 148fe295b7: hwsim.ap_long_preamble.fail
Message-ID: <20201012230118.GA19671@intel.com>
References: <20201002082945.GJ393@shao2-debian>
 <ffe9deeeb714d233c47d693c899f9577@adapt-ip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ffe9deeeb714d233c47d693c899f9577@adapt-ip.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Oct 02, 2020 at 09:38:45AM -0700, Thomas Pedersen wrote:
> On 2020-10-02 01:29, kernel test robot wrote:
> > Greeting,
> > 
> > FYI, we noticed the following commit (built with gcc-9):
> > 
> > commit: 148fe295b7d9d892b2b0f47070233ccdc70c83cd ("mac80211_hwsim:
> > indicate support for S1G")
> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
> > 
> > 
> > in testcase: hwsim
> > version: hwsim-x86_64-6eb6cf0-1_20200619
> > with following parameters:
> > 
> > 	group: hwsim-04
> > 	ucode: 0x21
> > 
> > 
> > 
> > on test machine: 8 threads Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz
> > with 16G memory
> > 
> > caused below changes (please refer to attached dmesg/kmsg for entire
> > log/backtrace):
> > 
> > 
> > If you fix the issue, kindly add following tag
> > Reported-by: kernel test robot <rong.a.chen@intel.com>
> > 
> > 
> > 2020-10-06 00:22:09 	./run-tests.py ap_long_preamble
> > DEV: wlan0: 02:00:00:00:00:00
> > DEV: wlan1: 02:00:00:00:01:00
> > DEV: wlan2: 02:00:00:00:02:00
> > APDEV: wlan3
> > APDEV: wlan4
> > START ap_long_preamble 1/1
> > Test: AP with long preamble
> > Starting AP wlan3
> > Failed to enable hostapd interface wlan3
> > Traceback (most recent call last):
> >   File "./run-tests.py", line 533, in main
> >     t(dev, apdev)
> >   File "/lkp/benchmarks/hwsim/tests/hwsim/test_ap_params.py", line
> > 821, in test_ap_long_preamble
> >     hapd = hostapd.add_ap(apdev[0], params)
> >   File "/lkp/benchmarks/hwsim/tests/hwsim/hostapd.py", line 581, in
> > add_ap
> >     hapd.enable()
> >   File "/lkp/benchmarks/hwsim/tests/hwsim/hostapd.py", line 248, in
> > enable
> >     raise Exception("Failed to enable hostapd interface " + self.ifname)
> > Exception: Failed to enable hostapd interface wlan3
> > FAIL ap_long_preamble 0.064398 2020-10-06 00:22:09.608978
> > passed 0 test case(s)
> > skipped 0 test case(s)
> > failed tests: ap_long_preamble
> 
> This is actually a bug in hostap which was exposed by this commit (and fixed
> by https://patchwork.ozlabs.org/project/hostap/patch/20200827225940.18151-1-thomas@adapt-ip.com/).
Thanks for the info, we have upgraded hwsim test suite to contain this fix.
And apologize for the false positive.

> 
> -- 
> thomas
>