Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4685412pxu; Tue, 13 Oct 2020 04:56:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLtCCQ+lmzRhrTq4SNKTMCWsvF+pIwa/yl0BeSeTK2hrisx4XgX2Ysjia24eB4bibHIzBE X-Received: by 2002:a17:906:a454:: with SMTP id cb20mr2698010ejb.137.1602590165091; Tue, 13 Oct 2020 04:56:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602590165; cv=none; d=google.com; s=arc-20160816; b=Bj/nsWLuh+qoUWP1FAPNGgLHURUZ+Q431yGF9fBYx/n4kw4VwPGrZre3f0KJf/+eYb 6aBQBeJII7dq6x0eGe1NwgIV9AF2pRSTnf04dGhM224w9dv6aSjoZoOgqRMWAedBN5F1 QaQo20nmTfLwl0gga3OM9voEhKpJK6MjP6EvvHTefFXLldc8TEdnlylXFZ69sc860euL xcG5mS8DUFugP7xPAwWk+iNQXWLiIf7bPoebfVESFPDPS5g/HSTvw0h6JjZ22PkWqQ0w yBk1qvvt2DaIdjeGkIt2fix8VsNDC4ww+EHg0j5/88hQNggJa4Nu8idLVTIf2D7Gp/Fe 89ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=SnZXbG947U3shmNP0kXgOzXpB/lKvZsOvPsRl917u3w=; b=WkQWkEhOfKfr0q629V4vNSy3q19wVEwo6OWW+a2jhOoJXsgYyp2JEAH0vPavcbAOtt zit7+3WA+glYT4lYIq7JXITaQEb9lORWk7NemOe/N1BM2nPH/ZoV2+Ne4mrgUFjp+2/k jg3+s6RsvMkhFmCL1mJJt08lNbaSMfXNqBQk1bNfnu93kCMKzCXI7VEtBY+jUJug66Q9 4nGAQfJyr5yYhUmIQLWCm41BKqT5DcpZ9OxYhsSmb8hUMrCaih/CtioBTkMvXR6ZZPSk TrIRloxiFMPYbN8n7+IeA87qDEtQgHApvzuJOFyYpcMmofe177Lskb9bCeQ0Mh6yUZzF PSIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q12si13634067ejs.146.2020.10.13.04.55.42; Tue, 13 Oct 2020 04:56:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389690AbgJMGoE (ORCPT + 99 others); Tue, 13 Oct 2020 02:44:04 -0400 Received: from lucky1.263xmail.com ([211.157.147.134]:40410 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389640AbgJMGoD (ORCPT ); Tue, 13 Oct 2020 02:44:03 -0400 Received: from localhost (unknown [192.168.167.16]) by lucky1.263xmail.com (Postfix) with ESMTP id 68E1FC3239; Tue, 13 Oct 2020 14:37:34 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P30218T139798958167808S1602571053396950_; Tue, 13 Oct 2020 14:37:35 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <3f72093f1ea45d218446f5d8a608d148> X-RL-SENDER: jay.xu@rock-chips.com X-SENDER: xjq@rock-chips.com X-LOGIN-NAME: jay.xu@rock-chips.com X-FST-TO: linus.walleij@linaro.org X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 X-System-Flag: 0 From: Jianqun Xu To: linus.walleij@linaro.org, heiko@sntech.de Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Jianqun Xu Subject: [PATCH v3 2/3] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq Date: Tue, 13 Oct 2020 14:37:30 +0800 Message-Id: <20201013063731.3618-3-jay.xu@rock-chips.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201013063731.3618-1-jay.xu@rock-chips.com> References: <20201013063731.3618-1-jay.xu@rock-chips.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There need to enable pclk_gpio when do irq_create_mapping, since it will do access to gpio controller. Reviewed-by: Heiko Stuebner Signed-off-by: Jianqun Xu --- drivers/pinctrl/pinctrl-rockchip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 927d132d6716..a2f361aa6d05 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3157,7 +3157,9 @@ static int rockchip_gpio_to_irq(struct gpio_chip *gc, unsigned offset) if (!bank->domain) return -ENXIO; + clk_enable(bank->clk); virq = irq_create_mapping(bank->domain, offset); + clk_disable(bank->clk); return (virq) ? : -ENXIO; } -- 2.17.1