Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4685745pxu; Tue, 13 Oct 2020 04:56:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAnRzl5iAjRHS3B69ahay8K7WNwgwNv+mVX1QCyfNWl0Se1HZnR9FGBvxVKIsQXnzL9uBp X-Received: by 2002:a17:906:54d8:: with SMTP id c24mr14716282ejp.499.1602590197369; Tue, 13 Oct 2020 04:56:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602590197; cv=none; d=google.com; s=arc-20160816; b=XXH5Db2zdI+JIEEVFfCUkmJY4HnoRopvqJRhyjcRQQzGy2qq/R/VmCyZCOqL4wwLTq YCAD9m2PrZgVf/9hcLjpc4dZ2hjjBizU6rHpGDaDDJ2eDP3fd3+8Dp3mOQGPUzJM997D tinafQQXEpadkehwHliSZF3P8XuqOJEcQXdFHQfH/Z0imUXQrH5abtr2OHK43340IhT9 jrkMa50NajuVgi9AuwcIDVMIlTssCUEaNF0PT+yHzdYt0dGktVLAkjICjABM/RbLMswg JW5X43x4VjPK1xD2a0j4TeF5kn6Fs0bjEBqKF1Qvu6kb78KUR5zVWBAUwx7/v1mFtIAC 8xDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=/4qpHbIhdK1Fq5C16VjIDCHq4Puc6PjT0B8hICICkdA=; b=ZbuYiXqHouoH7YJdru7yLi4/4W/1YQJzj7pSsXyM9VEbvLEeFp24LewE1lTB7nPQAd VCEKzjAKAXFIa84YGOUQ81u6Xc+VLPlU61uRwtDa1BpSph9B/ARUuDbw+emhQyN4co9k 3Q34euVIK9j2ZeoZhVnYuxfz+GguonBHbCJPDnh0LqOsyoyxSfIupl3NW+TnOd2WvkD/ gg35qhWHadfEteaVt/enME4DonCz5gzxK2lY5NuW8ItWfdDRPckKRGErK1Os3e3YAN5l OlxeGb4qxK39YX4XaBLqpHZSqh1auyDhFGicTxsywiDEKurXo4QUtLCRAtWIQ9xcaUFD IXvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a15si10432458eju.63.2020.10.13.04.56.15; Tue, 13 Oct 2020 04:56:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389793AbgJMGwe (ORCPT + 99 others); Tue, 13 Oct 2020 02:52:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:48790 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389637AbgJMGwe (ORCPT ); Tue, 13 Oct 2020 02:52:34 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 013F7AEA8; Tue, 13 Oct 2020 06:52:33 +0000 (UTC) Date: Tue, 13 Oct 2020 08:52:32 +0200 From: Daniel Wagner To: Finn Thain Cc: Nilesh Javali , Arun Easi , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] qla2xxx: Return EBUSY on fcport deletion Message-ID: <20201013065232.hdyjdkurkmowkf2f@beryllium.lan> References: <20201012173524.46544-1-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2020 at 10:59:18AM +1100, Finn Thain wrote: > > On Mon, 12 Oct 2020, Daniel Wagner wrote: > > > When the fcport is about to be deleted we should return EBUSY instead > > of ENODEV. Only for EBUSY the request will be requeued in a multipath > > setup. > > > > Also in case we have a valid qpair but the firmware has not yet > > started return EBUSY to avoid dropping the request. > > > > Signed-off-by: Daniel Wagner > > --- > > > > v3: simplify test logic as suggested by Arun. > > Not exactly a "simplification": there was a change of behaviour between v2 > and v3. It seems the commit log no longer reflects the code. How so? I am struggling to see how it could be a change in behavior. But then I sometimes fail at simple logic ;) v2 and v3 will return ENODEV if qpair or fcport are invalid and for EBUSY one of the other condition needs be true. The difference between v2 and v3 should only be the order how tests are executed. The outcome should be the same.