Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4687911pxu; Tue, 13 Oct 2020 05:00:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVt1hNxvWCs3cN5IkC/p29zdOrmwHs34yAyzyFS923QUf4jyIBnEFCmmn16rb9k03fG8xk X-Received: by 2002:aa7:d484:: with SMTP id b4mr19945487edr.288.1602590412779; Tue, 13 Oct 2020 05:00:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602590412; cv=none; d=google.com; s=arc-20160816; b=VvtXF1voVIc/EEOpIzSbvfse748enqfFn0tn3u9DeztlVwzpXLhRjZHSewEKARdB35 uh8TFs2dgIUNd+OnwxDOnCg0eZpBjnHo7yNMIaDaKwIz9I8+892emM6WsmrU/kWh97fB XqcE95P6SzPu0STFtlF7FfDepLguwFhH5NnZa1iYS+ORrr3XxTSxDWwEfVhZ4/XmQpJZ QOSkE7OgIJwvqyBOg9Buk74qhyGyIVd1s5Cg7LOcV0dpn2U7kn/ntPSkc2WwXFPIwe1q RYI0M45wHIlBx2WpXWm0WnNuu6Ui2CoWzFtcCq/FndI/TaThDjutTdwfBJsv0I5IPnNx zLCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=OEEVMQlwwgj5ImRxBIb1OSexx/RD4f1F9hD+AOvze9U=; b=T2Wt9eiGkJsT+wOoLco1ZlqfFkAwWPjntrQQX1yO9rGP5eK8SyWTpam2Wum+uCcdk5 3kgzHlhB6iHc3cubUVLSYZ7y3ZndxDbt2U5ZrT2fsqMsqyq8zm0EoUxpJ0Z3xZLJZNc5 7UIJcuo8e2KI56oYyJ9hst6C2hCgBpa1xpfgLlTLcthfeNuAJwlhQap4xbo+53k5RJtv V77FDr7zKNg/nCsSpsSipMoqJI+UzlOH2sY/JBFDFDbjBN9HzCKdl2JsFa5219ddk4ns Oozsp49Lb9+ucJshZ8enbfx1AGVwWNuh/Y2zJXfd09yo3JxF+oaFrkAoSso6lPkF0tRd ox2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s5si15321986edj.285.2020.10.13.04.59.49; Tue, 13 Oct 2020 05:00:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403877AbgJMIfA (ORCPT + 99 others); Tue, 13 Oct 2020 04:35:00 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44621 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403873AbgJMIe7 (ORCPT ); Tue, 13 Oct 2020 04:34:59 -0400 Received: from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kSFlh-0004Wx-Fy; Tue, 13 Oct 2020 08:34:49 +0000 From: Kai-Heng Feng To: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me Cc: Kai-Heng Feng , linux-nvme@lists.infradead.org (open list:NVM EXPRESS DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] nvme-pci: Disable Write Zeroes on Sandisk Skyhawk Date: Tue, 13 Oct 2020 16:34:45 +0800 Message-Id: <20201013083445.12317-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200723155731.22313-1-kai.heng.feng@canonical.com> References: <20200723155731.22313-1-kai.heng.feng@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Like commit 5611ec2b9814 ("nvme-pci: prevent SK hynix PC400 from using Write Zeroes command"), Sandisk Skyhawk has the same issue: [ 6305.633887] blk_update_request: operation not supported error, dev nvme0n1, sector 340812032 op 0x9:(WRITE_ZEROES) flags 0x0 phys_seg 0 prio class 0 So also disable Write Zeroes command on Sandisk Skyhawk. BugLink: https://bugs.launchpad.net/bugs/1899503 Signed-off-by: Kai-Heng Feng --- drivers/nvme/host/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 8984796db0c8..d310d7317e2a 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3187,6 +3187,8 @@ static const struct pci_device_id nvme_id_table[] = { NVME_QUIRK_IGNORE_DEV_SUBNQN, }, { PCI_DEVICE(0x1c5c, 0x1504), /* SK Hynix PC400 */ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, + { PCI_DEVICE(0x15b7, 0x2001), /* Sandisk Skyhawk */ + .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) }, { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001), .driver_data = NVME_QUIRK_SINGLE_VECTOR }, -- 2.17.1