Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4690590pxu; Tue, 13 Oct 2020 05:03:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzdiILsGOUnTOIUovzCJm4YHLyrTH3hd13mdL2bO5aXcBsyNxRo6aJy6wHhIePus0yyGhG8 X-Received: by 2002:a17:906:490d:: with SMTP id b13mr32359246ejq.122.1602590595971; Tue, 13 Oct 2020 05:03:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602590595; cv=none; d=google.com; s=arc-20160816; b=VlnJ4mKy/YLeoZHeZn/uvX7A5g+uJ8oKA65NzE3HpiJAWrxKvRgDqWQ716JSTwYqoE WyR8IE7GJa/iqk6Zbry68hUx86K3gwuD0TA/GUxwwJxqWwSaY3RfTYEPJAbqRjDcKqnf bhSHcoQt9Sm6Bb9mKtY8RNjEyDYyQvgWAnm44ZlNUYh4ufIfTOt4lN4AZHEBG+uT9dxu pDgS10o6GyDJ17YspzKirW5VxnubeULPFWzkStvl3wJ7CXR5vjxjzN8r3j4i+Y6IfRMx 2o9X7y9cOTqhuNIdm/MQGH1vjAZIi+7uz1v2LZrsR9mLUE8m9Ruxwf8eQmXeHia12Ycf UYoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=zIgjMo50ab2XkGZyZG3NWQ6CyLdzWANRqjic+iQCf9Y=; b=H9FBMOCHR4wjm3/f9sGRSGTsTX88MbsER2/VCYlGSUowztlVEhQNViKojWl4p/7DXW IEVIEt+kfgsPGCW0Mx9HaydowCSfSC/UkuM+0gWaRe/plVQ3giKzSXz3mdJ8BngWNb1E eP7sHnSxwazNkSBwkIpqohrS1k8gkRvT9DGz4B6da3VAv18Jo+drFKlW548T2yJ1s3lm KpiSBQfup4qXVKVR325hGj6ADC8BGJj6GXEUxTgsQqg7BYyycM7ya9v1r0CXA3TCvyFd LlUD/7CajICtyJPMZ86rTFN6cdXcfkYVYfwejJvwEa1DHYEMkadVegHU4DniEPxcs/1m wOUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lj17si14477374ejb.12.2020.10.13.05.02.52; Tue, 13 Oct 2020 05:03:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730839AbgJMKcy (ORCPT + 99 others); Tue, 13 Oct 2020 06:32:54 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:45920 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729468AbgJMKcy (ORCPT ); Tue, 13 Oct 2020 06:32:54 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id A88C9FB06; Tue, 13 Oct 2020 12:32:50 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l9H17qvFqi9u; Tue, 13 Oct 2020 12:32:49 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 86125402F3; Tue, 13 Oct 2020 12:32:48 +0200 (CEST) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] drm/panel: mantix panel reset fixes Date: Tue, 13 Oct 2020 12:32:45 +0200 Message-Id: X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The first patch in this series fixes dereferencing a NULL mode in the error path. The second one extends the resets to not only reset RESX but also TP_RSTN since otherwise the display will stay completely blank. I didn't spot that before initial submission since the reset line was bound to the touch controller and although that failed to probe it came far enough to deassert the reset line (at an arbitrary point in time during boot) and hence we got a picture. Since touch and panel are on the same IC they're not completely independent and i might have to turn the whole thing into an MFD at some point but this series gets the panel to a reliably working state on boot and on fb blank/unblank. Since the reset-gpios are active low we can deassert in prepare and assert in unprepare simplifying the code making sure lines are kept low when the panel is off. The binding were not part of a stable kernel so I hope it's okay to not worry about backward compatibility. Changes from v1: - As per review comments by Fabio Estevam https://lore.kernel.org/dri-devel/CAOMZO5B5ECcConvKej=RcaF8wvOxgq7nUzKJ-ad0aSAOzUqtbQ@mail.gmail.com/ - Fix typo in commit messages - As per review comments by Rob Herring https://lore.kernel.org/dri-devel/20200929174624.GA832332@bogus/ - Don't use an array of reset lines Guido Günther (3): drm/panel: mantix: Don't dereference NULL mode drm/panel: mantix: Fix panel reset dt-binding: display: Require two resets on mantix panel .../display/panel/mantix,mlaf057we51-x.yaml | 4 +++ .../gpu/drm/panel/panel-mantix-mlaf057we51.c | 25 +++++++++++++------ 2 files changed, 21 insertions(+), 8 deletions(-) -- 2.28.0