Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Xvpqxlhl4wwiS7y0TSejNfA+9gwuJeKsh2bCqwSmJ8MXZqtr2HnbNC/OqxD27RTwe9dKCJGQQ3
 tFUQr48x7AEQ==
IronPort-SDR: 4DLS+NwWImG7ltnbt45OuGGxGfkBzEsEWhp/3BkEZOwoeK64dwt3EgnXutdmw/HWlL1xeJscVv
 E0Vw0vVyR4Fw==
Date:   Tue, 13 Oct 2020 14:43:25 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc:     andreas.noever@gmail.com, michael.jamet@intel.com,
        mika.westerberg@linux.intel.com, YehezkelShB@gmail.com,
        gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: Add the missed ida_simple_remove() in
 ring_request_msix()
Message-ID: <20201013114325.GK4077@smile.fi.intel.com>
References: <20201013024518.195557-1-jingxiangfeng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201013024518.195557-1-jingxiangfeng@huawei.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Oct 13, 2020 at 10:45:18AM +0800, Jing Xiangfeng wrote:
> ring_request_msix() misses to call ida_simple_remove() in an error path.
> Add the missed function call to fix it.

...

>  	ring->irq = pci_irq_vector(ring->nhi->pdev, ring->vector);
> -	if (ring->irq < 0)
> +	if (ring->irq < 0) {
> +		ida_simple_remove(&nhi->msix_ida, ret);
>  		return ring->irq;
> +	}
>  
>  	irqflags = no_suspend ? IRQF_NO_SUSPEND : 0;
>  	return request_irq(ring->irq, ring_msix, irqflags, "thunderbolt", ring);

According to your logic don't you need it here as well?

-- 
With Best Regards,
Andy Shevchenko