Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4807810pxu; Tue, 13 Oct 2020 07:38:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvp5uxeKX2T4IgRzsDCmHEL98YhmmO0dlj5sJevJXPmV/dytpO49ZGzaAWR7E3kQI9X322 X-Received: by 2002:a17:906:9483:: with SMTP id t3mr54688ejx.390.1602599889083; Tue, 13 Oct 2020 07:38:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602599888; cv=none; d=google.com; s=arc-20160816; b=EyHt04Wv8sqRTLAfHELX4jBdRProaUitkJXbMw9WkEFMkGic14VC/sQtfftGKriyoB xvNj1LEHTBHm5q6Azn1W2reon1GO4UAM1xYrXiTcW26PP8Zd333mgqWNU0VD2cPlAuJf aKj1m2BQUZLutqGf5V+bUYNcDP6SY2iEkZPctOGpGlIdQcHdJL4TdziEv9Rjb87iPHQO +YQpGcEXC8qd7fWw3wz82lIiwszEsAZN7ulOqY6DuZ/X9sxmuiZDnKDKoz9ZLGHlf5n5 T6PatJroB2NkTnWAbzCk4gNpfP+wRYvskZS9U8zvPxYY5zZF9lvTRea9fLzmkNx4bJ9/ fytA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=J4SqumeB1YgQv0x1Jm7d/tqmvbX1crmxlaZ1m5MG3oA=; b=YCg/OP4TamDdqrMysMThxa6XvqsPTGDyVPrlnAUtvzl28rIep+x6KVkzWrhsAPaz9G R7AYD1K3A5zGEDui71LJ6k7uFKbicBBi+JsUeeryS5CbFxkjeg8UTUXfn3jsidWkm2fn ncUoeQLt5MSxYy5N3G0sawJGOBWstoFhdDMg5nP+tdbbkLLRGjjboHEouVnQ7WgIFJ2Q Bx+KjB16vO9pm8uR2C2wB2xecS9j3KwkxrP6+FvJbuA0WYZvA+0qZ3UzxOxUCi+ux5fo db5qBhuvGPgX5U8n0wd0jxEHbEf4BV9sPQOG5iP3U/eaJHFHmxU4GMKJ9M7yqO0AwZxJ z+0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OfDqbVxF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p9si9039838edy.462.2020.10.13.07.37.40; Tue, 13 Oct 2020 07:38:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OfDqbVxF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388629AbgJLWTL (ORCPT + 99 others); Mon, 12 Oct 2020 18:19:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388218AbgJLWSk (ORCPT ); Mon, 12 Oct 2020 18:18:40 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63EC6C0613D1 for ; Mon, 12 Oct 2020 15:18:40 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id b1so16541022lfp.11 for ; Mon, 12 Oct 2020 15:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J4SqumeB1YgQv0x1Jm7d/tqmvbX1crmxlaZ1m5MG3oA=; b=OfDqbVxFOqGLzYnhHrZ0IFyNDqkjxi9b8KIlZlFxr/y3V6zSeWSlSYMumsdSf/3aBM KG/sz0uoSJ9IEizz8W76tcT7yk+69T2nOaH4rGM0h3lHJpvLvEeV9oteYD6I/xqMrofs YAoIa1BArYx2BLuriJf0imGLucEJRG0jzPab3AMNRPUuMXfmlpI1ISFgtDJt298I5Saf 8PKLt5Jmeo3QFN/eNaVBJLjjlaYcBcZsNOmmJ+TvKABqJXKREhTjI2zSbTedNMG8Ui/j 2f7wzuhie2UTjVgyWRTGTH33aoTPrifydj9FF8cGeiuHDGze1SnrtjS7o8N32zgiICAw wl8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J4SqumeB1YgQv0x1Jm7d/tqmvbX1crmxlaZ1m5MG3oA=; b=FI0e3tfnjUyLzRmI9QWdTn8oxvkwzAEjIYAAyz/ANiHGZRjNmPC19hD0SwjQo6jBs/ rxiqjS8vx/tKlJNm125qZBBTRZSWxidUBu6j19IBzymOOTfLPcgR5lZ97r/faCTieHS9 wIyGrZWZYajxPuxcWkZe4qy5xYFN4g2XGKRvfZ1hfSI15aOOrCpeo6zqf6FQgrZx+y/C JuRKuy9Y8jF2cVrMo8VFO2lGhm3X8vIQyhiE40AKJ14huDDI+/PK+TYBCLloGsffA0YU djw+5uPGS9gEyrMi4yQl+zk0sXKs4dOiKKWm+WyiLFshyczmYOYflzvctmfzAcE2XmCe n1bg== X-Gm-Message-State: AOAM5334yE8wwrU5KZ8x/WMx4O0MtBsrAsNroxcId1w3R9Nv7YNWcyNN lZkhtbsfazENIAWSkyeUxTDN0QNeH0/sJH+BUDVBPA== X-Received: by 2002:a19:8191:: with SMTP id c139mr8154062lfd.333.1602541118637; Mon, 12 Oct 2020 15:18:38 -0700 (PDT) MIME-Version: 1.0 References: <20201008154651.1901126-1-arnd@arndb.de> In-Reply-To: <20201008154651.1901126-1-arnd@arndb.de> From: Linus Walleij Date: Tue, 13 Oct 2020 00:18:27 +0200 Message-ID: Subject: Re: [PATCH 00/13] Clean up legacy clock tick users To: Arnd Bergmann Cc: "linux-kernel@vger.kernel.org" , Russell King , Tony Luck , Fenghua Yu , Greg Ungerer , Geert Uytterhoeven , Finn Thain , Philip Blundell , Joshua Thompson , Sam Creasey , "James E.J. Bottomley" , Helge Deller , Thomas Gleixner , Daniel Lezcano , John Stultz , Stephen Boyd , linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-m68k , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 8, 2020 at 5:47 PM Arnd Bergmann wrote: > When I created the patch removing CONFIG_ARCH_GETTIMEOFFSET, > I also had a look at CONFIG_GENERIC_CLOCKEVENTS, which is > selected by most, but not all, platforms today, each of the > ones that lack it doing the timer tick slightly differently. > > The cleanups here make the old platforms a bit more > consistent, in multiple ways: > > - rather than selecting GENERIC_CLOCKEVENTS on modern > platforms, select LEGACY_TIMER_TICK on the old ones. > > - Hide some more of the internal implementation and only > provide a single common entry point for the timer tick, > which also makes the behavior more consistent. > > - Remove the m68k and arm specific infrastructure pieces > and call the common helper directly from each timer > interrupt function. > > I tested the series on m68k with the qemu q800 target > platform, both with the legacy_timer_tick() implementation > and after converting that to a periodic clockevent driver. I am a big fan of this patch series: Reviewed-by: Linus Walleij Maybe the RFC patch can be kept in the sidelines but the rest should be merged ASAP in my opinion, the kernel just looks so much better after this. Yours, Linus Walleij