Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4895543pxu; Tue, 13 Oct 2020 09:33:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfjLGpDvzLVNlMuAl/HgjM9QM7pEY9koFToCP7oszAsNVLP9ALbpPdL7Mf5BRGXI6RwmFi X-Received: by 2002:a50:950e:: with SMTP id u14mr394463eda.260.1602606831776; Tue, 13 Oct 2020 09:33:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602606831; cv=none; d=google.com; s=arc-20160816; b=hS5mkam7VxiHkNN+Rf2EkanilCT+m1ZVOBAjA6tKd2NVw4SYgkcnE0bwbWrx3bq30p 6UMzwUecsiZ3KIQys/PMBVm381n9+uksI4vhQnCLVVS4e2S49PG/SNE7Hrcz7T1XrViX 42YkbPE9sFglE+dnxXg6hC2dJqDEKOfVbnSOTO7prIySjUCMftytmoyetF4kCSjwKypH mxByLZbWGni2OdT3TIEjGqe5Q3FO88tyxiPsdasHoxrugN9Fd3Atnfqvk9taxgJ9OaPZ rRMtUQTqaglhv9EcwOgoOvSX+okF1TULq/k1oy3DctuqSot1A9cDwzUwOkH4m3yZddqI gssQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=Ybw2TtheIXdmnqThMw0ttHoeclieIeXDL4yEWWA/spg=; b=d0A4s5IaWc3yPooLMlh6LOUEqOFN3i64bjxLd8nNWmDo6toyJfwCnnF6+39PImp7F8 ays+EFVC/hwZRn6cjyPu9ffDR61Gv2rZDpt9lMZHv+Aq7dBe2hT8TeMEaiLlvLw/25Ex xyK32VhnGwvu91LEpgL5nMhc6ozB347SBzKhq4WBtWkp2Gan8lPIpHnqRN8P1S75FZd/ 8eNsw6CUjiLGXD4yXWT0Q3Zcef5vrWhPgAushoNTi76chR+QQzhtm9/0pJ/fJpYwmBfO Jl2rhEbJf7Vai9H9EgfzaUpEqbeG+ohXvAJ9dO6N1ces+SmfDf3Z/fxKR2PpDodiXiYo 7rVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si135955eds.296.2020.10.13.09.33.29; Tue, 13 Oct 2020 09:33:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387570AbgJMNFP (ORCPT + 99 others); Tue, 13 Oct 2020 09:05:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:60320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387449AbgJMNFP (ORCPT ); Tue, 13 Oct 2020 09:05:15 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC19922B2D; Tue, 13 Oct 2020 13:05:13 +0000 (UTC) Date: Tue, 13 Oct 2020 09:05:11 -0400 From: Steven Rostedt To: Yafang Shao Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: add tgid into common field Message-ID: <20201013090511.1f2f71f6@gandalf.local.home> In-Reply-To: <20201013055454.52634-1-laoar.shao@gmail.com> References: <20201013055454.52634-1-laoar.shao@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Oct 2020 13:54:54 +0800 Yafang Shao wrote: > --- a/include/linux/trace_events.h > +++ b/include/linux/trace_events.h > @@ -67,6 +67,7 @@ struct trace_entry { > unsigned char flags; > unsigned char preempt_count; > int pid; > + int tgid; > }; > Sorry, this adds another 4 bytes to *every* event, if you want it to or not. I'd rather have some ways to remove fields from this header, and not add more to it. I can't take this patch. -- Steve