Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4973114pxu; Tue, 13 Oct 2020 11:25:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwqYjXJU6MPtOrBfw1vOBXNvaeNFHZl98nbAOztG9XxZaocDPD9K06wKBC6+EbkPgR5WhI X-Received: by 2002:a17:907:2089:: with SMTP id pv9mr1071031ejb.427.1602613534152; Tue, 13 Oct 2020 11:25:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602613534; cv=none; d=google.com; s=arc-20160816; b=LNKTCfIkhn3o6vcxL5WZQ4Yh9ajmg5vdbc6XAxzyIUdBEX11hqL8k4EXSwq76zj6e3 s08Xdv9xHEy/dXoGT+UysVRzSA6iwVshGbkiE7T+PegPgVqRvuc6mcKlieulVlmXrsoJ 9HyfCZtdqyqA+msgRYwUAvrqJo33C6w+Dt+JkPIDQo3lSVR/0yc1z+ln88XbNHcBOZEM RNTO/q7eqGMbyCXxH29Y08c3ztsuJjv01Fagcy0ImYKLpVq6xj1qYPHiwArXHMIGreaE G6dFUtU5KSKqkPEbLGia5zEi7g3IoikW9CbgGr1DhorHs4vNEDXze5EO/J8D3p8RsV/q I7ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=/X0l/lq8GHuZ6wwPRT0Y4/J55/Ri/zgO+IG/lXyGGo0=; b=YfHFQc9E0FM6sj1VGI/qwVAWU52opfRDBZhAX0UAI15EJum4gJTOVFg08vqy71N4wy GwA62m1bYBe6g5H0+uhhMWjK8VyoCmaYINVYX5K1qNDyTsiKtiVSd+qVoMEZgNkO/eJL ZjLH8h5HpKrq+1BiXPwe+PuDlzg4OMRLbXe6k8sCn+HsNNOkGiKH8Py1FC6bMDE2z2qg sN+36lULMa7oi5B2am06D7dm0TcCCfk981nxpbe/p+e4xJTdYmK88CMn6fz6t5Nu79VO RgfX6jAwoQdLVWrNpPzNPwKNyN8ngDfCArmfarQCaVuUOVruRWFp7LdzSuCuhg9iDs7a X+rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i13si352611edq.350.2020.10.13.11.25.11; Tue, 13 Oct 2020 11:25:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387569AbgJMKdF (ORCPT + 99 others); Tue, 13 Oct 2020 06:33:05 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:45966 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729468AbgJMKc4 (ORCPT ); Tue, 13 Oct 2020 06:32:56 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 1FA8DFB05; Tue, 13 Oct 2020 12:32:54 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HVnsScNImAzv; Tue, 13 Oct 2020 12:32:50 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 8CEE6402EC; Tue, 13 Oct 2020 12:32:48 +0200 (CEST) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] drm/panel: mantix: Don't dereference NULL mode Date: Tue, 13 Oct 2020 12:32:46 +0200 Message-Id: <659158549f3c6cc1c71ceed0943e760e861c1206.1602584953.git.agx@sigxcpu.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't dereference mode which was just NULL checked. Signed-off-by: Guido Günther Reported-by: Dan Carpenter --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c index 3482e28e30fc..4a7fbf64bb7a 100644 --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c @@ -204,7 +204,7 @@ static int mantix_get_modes(struct drm_panel *panel, if (!mode) { dev_err(ctx->dev, "Failed to add mode %ux%u@%u\n", default_mode.hdisplay, default_mode.vdisplay, - drm_mode_vrefresh(mode)); + drm_mode_vrefresh(&default_mode)); return -ENOMEM; } -- 2.28.0