Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Viorel Suman (OSS)" <viorel.suman@oss.nxp.com>
To:     Rob Herring <robh@kernel.org>,
        "Viorel Suman (OSS)" <viorel.suman@oss.nxp.com>
CC:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Timur Tabi <timur@kernel.org>,
        Nicolin Chen <nicoleotsuka@gmail.com>,
        Xiubo Li <Xiubo.Lee@gmail.com>,
        Fabio Estevam <festevam@gmail.com>,
        Shengjiu Wang <shengjiu.wang@gmail.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Cosmin-Gabriel Samoila <cosmin.samoila@nxp.com>,
        Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Viorel Suman <viorel.suman@gmail.com>
Subject: RE: [PATCH v3 2/2] ASoC: dt-bindings: fsl_xcvr: Add document for XCVR
Thread-Topic: [PATCH v3 2/2] ASoC: dt-bindings: fsl_xcvr: Add document for
 XCVR
Thread-Index: AQHWlkG0yVRccbzaGkOVtb/Lyfdk/amK8jIAgAqWdyA=
Date:   Tue, 13 Oct 2020 12:15:52 +0000
Message-ID: <VI1PR0401MB2272C7A52819364E674BA90492040@VI1PR0401MB2272.eurprd04.prod.outlook.com>
References: <1601371167-32239-1-git-send-email-viorel.suman@oss.nxp.com>
 <1601371167-32239-3-git-send-email-viorel.suman@oss.nxp.com>
 <20201006183442.GA2591611@bogus>
In-Reply-To: <20201006183442.GA2591611@bogus>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [86.127.156.60]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: bd60ca03-baf0-4bdd-128d-08d86f71ba6b
x-ms-traffictypediagnostic: VI1PR04MB5198:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <VI1PR04MB5198EF7A3F95497AC94C225BD3040@VI1PR04MB5198.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 713Tn/z/m4FfLCh6a4brM9A1Eu4SxUxMy/5acpjfJfGMQobmVjlaRpSE8piMyIfwvLr74OTQmnJ5MMUCPa2gt4aXM4fFPrMIaqWYJcbGV312lYeZmEOO7zkOxggSjH1ILcTFfqCuSJYO1JT4MYfbBLkQP28eNEs9npnGm+Szz2BD2EGCH1206g0lQGkIQN5HlByT+SXMwLmiFrrBKw4Ax4UrrwEmpMMOIfHkdLM0vGhjeSrxxX+PZM+sY3ILepOt8QZ/oONzJ/gtrk8EBcMh2Rx6RhkLhVa0CsM9dZjgEGCIyJtrI77fBB/pFO+67hTA1HUUo/uUSAkBztMhxEH7Dh21uWlbO4TY/+JM7x2CSWfTOiQ+ONumJGoGKRdU92mTORciDONqJDuF905MgAuHdg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0401MB2272.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(966005)(9686003)(2906002)(83380400001)(110136005)(54906003)(55016002)(26005)(7696005)(53546011)(86362001)(33656002)(71200400001)(4326008)(186003)(83080400001)(66476007)(66556008)(7416002)(498600001)(6506007)(64756008)(66946007)(52536014)(8676002)(76116006)(66446008)(8936002)(5660300002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: ikVhjsMJS2hDHVDuScffoU1j+S0/RHeZ0T9b29T08amLxnChQlwLYR4KSAVD5TbdHaPWfN58kCdCXgx5tAd4KSsm1ZHqXCbTV/RgfTVIVXu1245gbakohPFSmZlqXSj2qM9U0cmLVQCC9XogFFWgE+iH+03pgqQ+15Qhb8Iv8AQOaWoaha+Bf7FthC5dD4ezjgznOm0om5P9aSiNYc82mupkh9pBh+MHTTPi517PgYNsdT0nfoJVhSFCYppi5mv6g3UMmKFXFnuuBYhJBHbQJZSazgbY3gESogFuYHc7wbXfbuaCur8McXxBckMtK+xQCRTJxGj86JxIjx5neWI/rzK/2zvJRMyXdaScsIbhh3WI7TTA+aR7yXddgn7hhZQSAHAA29vVerh3gw7JrMXqd73o/MNiqg9o7XFTVe6ueDrNDIk0BwNeSrU9QamZ5JqqerWvnytGFRQ2I5CtHE76TH+hVpWA2GMXjm7x1pWpaaid5IJ/Fb8t3d1tly7EMVpG/eqHaZm7Ta4UBkrywxDoncNpiHhFVe12Hu9D5SpgYHucoItFFdai4W2EUspbSrRNfIiox30niwxa7yFK12S6CR354D2429DUtebP30W1sWydS2a1Sp+3HbFvBLpS82p54Mu3aIr5Lc7Ycch4P7LHHQ==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2272.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd60ca03-baf0-4bdd-128d-08d86f71ba6b
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2020 12:15:52.1402
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AaUz5gjj0FNwPPimnFRizBfMSKbvS39bKOLCFgZkPS+q7WJP1waX96AH7iRwMRP0nDQQ29VcpgRGzxT7ZvJcWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5198
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

Thank you for review, fixed in V4.

/Viorel

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Tuesday, October 6, 2020 9:35 PM
> To: Viorel Suman (OSS) <viorel.suman@oss.nxp.com>
> Cc: Liam Girdwood <lgirdwood@gmail.com>; Mark Brown
> <broonie@kernel.org>; Jaroslav Kysela <perex@perex.cz>; Takashi Iwai
> <tiwai@suse.com>; Timur Tabi <timur@kernel.org>; Nicolin Chen
> <nicoleotsuka@gmail.com>; Xiubo Li <Xiubo.Lee@gmail.com>; Fabio Estevam
> <festevam@gmail.com>; Shengjiu Wang <shengjiu.wang@gmail.com>; Philipp
> Zabel <p.zabel@pengutronix.de>; Cosmin-Gabriel Samoila
> <cosmin.samoila@nxp.com>; Viorel Suman <viorel.suman@nxp.com>; Matthias
> Schiffer <matthias.schiffer@ew.tq-group.com>; alsa-devel@alsa-project.org=
;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org; dl-linux-imx <linux-imx@nxp.com>; Viorel Suman
> <viorel.suman@gmail.com>
> Subject: Re: [PATCH v3 2/2] ASoC: dt-bindings: fsl_xcvr: Add document for=
 XCVR
>=20
> On Tue, Sep 29, 2020 at 12:19:27PM +0300, Viorel Suman (OSS) wrote:
> > From: Viorel Suman <viorel.suman@nxp.com>
> >
> > XCVR (Audio Transceiver) is a new IP module found on i.MX8MP.
> >
> > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> > ---
> >  .../devicetree/bindings/sound/fsl,xcvr.yaml        | 103
> +++++++++++++++++++++
> >  1 file changed, 103 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> > b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> > new file mode 100644
> > index 00000000..8abab2d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> > @@ -0,0 +1,103 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/fsl,xcvr.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NXP Audio Transceiver (XCVR) Controller
> > +
> > +maintainers:
> > +  - Viorel Suman <viorel.suman@nxp.com>
> > +
> > +properties:
> > +  $nodename:
> > +    pattern: "^xcvr@.*"
> > +
> > +  compatible:
> > +    const: fsl,imx8mp-xcvr
> > +
> > +  reg:
> > +    items:
> > +      - description: 20K RAM for code and data
> > +      - description: registers space
> > +      - description: RX FIFO address
> > +      - description: TX FIFO address
> > +
> > +  reg-names:
> > +    items:
> > +      - const: ram
> > +      - const: regs
> > +      - const: rxfifo
> > +      - const: txfifo
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    items:
> > +      - description: Peripheral clock
> > +      - description: PHY clock
> > +      - description: SPBA clock
> > +      - description: PLL clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: ipg
> > +      - const: phy
> > +      - const: spba
> > +      - const: pll_ipg
> > +
> > +  dmas:
> > +    maxItems: 2
> > +
> > +  dma-names:
> > +    items:
> > +      - const: rx
> > +      - const: tx
> > +
> > +  firmware-name:
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    const: imx/xcvr/xcvr-imx8mp.bin
> > +    description: |
> > +      Should contain the name of the default firmware image
> > +      file located on the firmware search path
>=20
> We generally only have this if the name/path can't be fixed (per
> compatible) in the driver. Given you only have 1 possible value, that doe=
sn't
> seem to be the case here.
>=20
> > +
> > +  resets:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - reg-names
> > +  - interrupts
> > +  - clocks
> > +  - clock-names
> > +  - dmas
> > +  - dma-names
> > +  - firmware-name
> > +  - resets
>=20
> additionalProperties: false
>=20
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/clock/imx8mp-clock.h>
> > +    #include <dt-bindings/reset/imx8mp-reset.h>
> > +
> > +    xcvr: xcvr@30cc0000 {
> > +           compatible =3D "fsl,imx8mp-xcvr";
> > +           reg =3D <0x30cc0000 0x800>,
> > +                 <0x30cc0800 0x400>,
> > +                 <0x30cc0c00 0x080>,
> > +                 <0x30cc0e00 0x080>;
> > +           reg-names =3D "ram", "regs", "rxfifo", "txfifo";
> > +           interrupts =3D <0x0 128 IRQ_TYPE_LEVEL_HIGH>;
> > +           clocks =3D <&audiomix_clk IMX8MP_CLK_AUDIOMIX_EARC_IPG>,
> > +                    <&audiomix_clk IMX8MP_CLK_AUDIOMIX_EARC_PHY>,
> > +                    <&audiomix_clk IMX8MP_CLK_AUDIOMIX_SPBA2_ROOT>,
> > +                    <&audiomix_clk IMX8MP_CLK_AUDIOMIX_AUDPLL_ROOT>;
> > +           clock-names =3D "ipg", "phy", "spba", "pll_ipg";
> > +           dmas =3D <&sdma2 30 2 0>, <&sdma2 31 2 0>;
> > +           dma-names =3D "rx", "tx";
> > +           firmware-name =3D "imx/xcvr/xcvr-imx8mp.bin";
> > +           resets =3D <&audiomix_reset 0>;
> > +    };
> > --
> > 2.7.4
> >