Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp4974209pxu; Tue, 13 Oct 2020 11:27:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyewDcdJBCOBlnbuulH5j4i2mYjeIriSmyVNv7med0JijTI1FuUBI/8ixl/dyNEWBTAYqzY X-Received: by 2002:aa7:cf95:: with SMTP id z21mr912214edx.346.1602613638477; Tue, 13 Oct 2020 11:27:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602613638; cv=none; d=google.com; s=arc-20160816; b=ydQvrCiVEYTjjugYGK/GE6M9Qtzh5mRFpquBU8UeuDjg7tr4II7vXTMBzUlBuBn3Fu aKPA+DxvxiPuHvcVcmitrmKAzZ+xeYr1w+ErXiIBWL/GS4mDwAWjUUwcSZvUXLa+PKHI XkDJX1iNCCVH7xkOAjNGK0IS0b2SH7aqWHJOKjnbwIObltUqI7RvPofbzZj9On0He8/V cuGIUS8Xurp8KXPQTW3GD0bG3YlSnQac9UA5s/z04IYdAVq7S28fs452ms/+glcmbtvW QhiXB/hVIN1cWhi1kpuuCrYP7rnrYgUaOTlh6HShl1A2FtPVzk1VwnM30dT9SGw9yfop gqdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8bDJucZgJh5FF2qZq2dSXU5O6ciFzNhYy3NAEbiOW5U=; b=x3Jk2QBDF3Ge6+EOBh4SY2EsXY/g1JhSIpXCE12KwaClguWr1Sk++GpGWbtAVgjBdw t34uGZ99NTN6E71f0CUjHGvaCOeptZhgE5F2xounoA0mAEd27ovFZxpDZ4zAo/Ukyy4t uO+SzyMzbLg1F8/MuT6+3B3t2YeIN8gZ+YM54d1Q9y7GQ6RDl5ILM1wOUmrbUtDefQ2l dHkUXmdFF6Yt2Lt4PKERQ6UFtNaogL2wOQxp4K3zzZFuOxHY548gl3KTvT6xtYqnGa1T FDIRs5nRslmAsCISoAy4z5609lF+fgZ1UHk7QkOauyQ1I6VAYJQXTSOcCRv87HOXuREa A4Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FYwrlQmK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yd16si379606ejb.505.2020.10.13.11.26.55; Tue, 13 Oct 2020 11:27:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FYwrlQmK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388209AbgJMN7W (ORCPT + 99 others); Tue, 13 Oct 2020 09:59:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387613AbgJMN7Q (ORCPT ); Tue, 13 Oct 2020 09:59:16 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FAF1C0613D0 for ; Tue, 13 Oct 2020 06:59:15 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id e2so50718wme.1 for ; Tue, 13 Oct 2020 06:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8bDJucZgJh5FF2qZq2dSXU5O6ciFzNhYy3NAEbiOW5U=; b=FYwrlQmKtFjItcjW6NkFA6usPpaoxqkvxN79cTvEqLVez2ARTv8noXL+aHKz9UF49Z yVXpMQ89CRyszsM4HeQ8CSiosmbuBKpjt0ILH+VmI+6+Umkf7ONAeQy+u3Xssg3oV9MM GmmHDplpH3S3q3zVshgXn5CD5HFk2UBehaCr8EeMGdI4NlsHu6/AE2j08dIwmK9WgY7v /7u/DY3dMA71zueWe76a1so59dbBTs3ApoT9oIYbcXPxWFzSwCygQcgV7D/V3RlOTI90 VPKw5NxJKEi5cqGslb9JoN6KvpqOWf2TRBZ7x6fed4Ukp+2xey6DZU+MkZVUU5eKBxtM GmHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8bDJucZgJh5FF2qZq2dSXU5O6ciFzNhYy3NAEbiOW5U=; b=navLAlxeMogvYVLigduC532R0H2edUFxPo3rh/zohUYuq85Y2u2tkEwKHY7ftrRWBO AH1vcn08x8PGzO/gxUnBlo+utkK7kQplcjoe/vjW0Tp0D5FYwf5GBk0n1UiPlLcqK47v UgNzhWAmFEvLt5QDyfrWW8vy3A8T/lBUrzm7D00y0rDu7O57Qjmh34SHFOfk7BIJ++rt Uo/kS8O06Wq4imdLO7gfu8Os7UsPhZvY8LTAfhvjl7zS/XNfEGSzpJWWjWbkTps0HPpN BLkpycKhbViy8izQOoj1XmHhI6MngURza5jxiU6N5ukp8z4Byuyiywqgsx6MRvZDL7w3 KEmg== X-Gm-Message-State: AOAM531rCFB3BQtHuIKqvbmQ4v/rQKH2tuJz4oyl8HlTpDFOxHpvwl6z FmTjo0ORYD8V/hMhKGD4Qu86wsHJWHchCA== X-Received: by 2002:a7b:c4cb:: with SMTP id g11mr78968wmk.88.1602597553753; Tue, 13 Oct 2020 06:59:13 -0700 (PDT) Received: from localhost.localdomain ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id a199sm17785wmd.8.2020.10.13.06.59.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2020 06:59:13 -0700 (PDT) From: Georgi Djakov To: linux-pm@vger.kernel.org Cc: mdtipton@codeaurora.org, okukatla@codeaurora.org, sibis@codeaurora.org, saravanak@google.com, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, Georgi Djakov Subject: [PATCH 2/3] interconnect: qcom: sdm845: Init BCMs before creating the nodes Date: Tue, 13 Oct 2020 16:59:12 +0300 Message-Id: <20201013135913.29059-2-georgi.djakov@linaro.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201013135913.29059-1-georgi.djakov@linaro.org> References: <20201013135913.29059-1-georgi.djakov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently if we use sync_state, by default the bandwidth is maxed out, but in order to set this in hardware, the BCMs (Bus Clock Managers) need to be initialized first. Move the BCM initialization before creating the nodes to fix this. Fixes: 7d3b0b0d8184 ("interconnect: qcom: Use icc_sync_state") Signed-off-by: Georgi Djakov --- drivers/interconnect/qcom/sdm845.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c index d79e3163e2c3..47556dc12ec0 100644 --- a/drivers/interconnect/qcom/sdm845.c +++ b/drivers/interconnect/qcom/sdm845.c @@ -489,6 +489,9 @@ static int qnoc_probe(struct platform_device *pdev) return ret; } + for (i = 0; i < qp->num_bcms; i++) + qcom_icc_bcm_init(qp->bcms[i], &pdev->dev); + for (i = 0; i < num_nodes; i++) { size_t j; @@ -512,9 +515,6 @@ static int qnoc_probe(struct platform_device *pdev) } data->num_nodes = num_nodes; - for (i = 0; i < qp->num_bcms; i++) - qcom_icc_bcm_init(qp->bcms[i], &pdev->dev); - platform_set_drvdata(pdev, qp); return 0;