Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] can: Explain PDU in CAN_ISOTP help text
To:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201013141341.28487-1-geert+renesas@glider.be>
From:   Oliver Hartkopp <socketcan@hartkopp.net>
Message-ID: <8e7bface-eef3-c5eb-a822-aec79c6992ac@hartkopp.net>
Date:   Tue, 13 Oct 2020 18:43:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201013141341.28487-1-geert+renesas@glider.be>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 13.10.20 16:13, Geert Uytterhoeven wrote:
> The help text for the CAN_ISOTP config symbol uses the acronym "PDU".
> However, this acronym is not explained here, nor in
> Documentation/networking/can.rst.
> Expand the acronym to make it easier for users to decide if they need to
> enable the CAN_ISOTP option or not.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>

Yes, when you are so deep into it that PDU becomes a word like dog or 
cat ;-)

Thanks,
Oliver

> ---
>   net/can/Kconfig | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/can/Kconfig b/net/can/Kconfig
> index 224e5e0283a986d9..7c9958df91d353c8 100644
> --- a/net/can/Kconfig
> +++ b/net/can/Kconfig
> @@ -62,8 +62,9 @@ config CAN_ISOTP
>   	  communication between CAN nodes via two defined CAN Identifiers.
>   	  As CAN frames can only transport a small amount of data bytes
>   	  (max. 8 bytes for 'classic' CAN and max. 64 bytes for CAN FD) this
> -	  segmentation is needed to transport longer PDUs as needed e.g. for
> -	  vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN traffic.
> +	  segmentation is needed to transport longer Protocol Data Units (PDU)
> +	  as needed e.g. for vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN
> +	  traffic.
>   	  This protocol driver implements data transfers according to
>   	  ISO 15765-2:2016 for 'classic' CAN and CAN FD frame types.
>   	  If you want to perform automotive vehicle diagnostic services (UDS),
>