Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAA_a9xLcCuR+WFfNtpJgq14rGZfxcqsoVz5aNhL5XCLhV+TwNg@mail.gmail.com>
In-Reply-To: <CAA_a9xLcCuR+WFfNtpJgq14rGZfxcqsoVz5aNhL5XCLhV+TwNg@mail.gmail.com>
From:   Alex Qiu <xqiu@google.com>
Date:   Tue, 13 Oct 2020 11:22:04 -0700
Message-ID: <CAA_a9xKLrcgDNpNF0dCGohUoV4igtZWmYTwjkT_GOQ4hyjY+oQ@mail.gmail.com>
Subject: Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1
 telemetry for RAA228228
To:     Grant Peltier <grant.peltier.jg@renesas.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Adam Vaughn <adam.vaughn.xh@renesas.com>,
        Guenter Roeck <groeck7@gmail.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Jason Ling <jasonling@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Jason pointed me to the patch
https://github.com/torvalds/linux/commit/294f69e662d1570703e9b56e95be37a9fd3afba5.
Nvm...

- Alex Qiu

On Tue, Oct 13, 2020 at 11:18 AM Alex Qiu <xqiu@google.com> wrote:
>
> (Intercepting the email thread...)
>
> Hi Grant,
>
> Looks like you made a typo in your patch:
>
> > + case raa_dmpvr2_2rail_nontc:
> > + info->func[0] &= ~PMBUS_HAVE_TEMP;
> > + info->func[1] &= ~PMBUS_HAVE_TEMP;
> > + fallthrough;
>
> Did you mean "/* fallthrough */" instead of "fallthrough;"?
>
> - Alex Qiu