Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp5021594pxu; Tue, 13 Oct 2020 12:42:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyg4r6wKSLCdjYcuWnGmW4iFWcYDopr3tjCg8k6VBTQD5+aPJK2o49ko9MRwBWQSLwlPFf0 X-Received: by 2002:a17:906:a859:: with SMTP id dx25mr1365978ejb.459.1602618159377; Tue, 13 Oct 2020 12:42:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602618159; cv=none; d=google.com; s=arc-20160816; b=TomrJ/NZPRHtwCigYHOkYsQr8s5TW1GvRJGFCGUACVYULzZwL4Wcn8k3JDT81zca6E Uy4I1QW+/iq86wrdNzqxciTiUbTlupJIgA7vAh/58g4YEbcgQh+1BNBmTDx3b1eygZT6 a1MnX/yB6fSYSmOOyhi05XJzOl8HnHQ3ZVxGCYeI074m++8hbdlyc6mdmFeyynKNPLwH 4Fi4Tpfa+L1PnnhVr+GdWvgQl5+7Y0yEur9S99hrqrFiHLwG4EopuNUciU+4Y6Y/5bbe KFuElPVwhC9YVhEma5GiYgV9yNXeCE50wFCET0yzDHi5+p1kMZT7TUSX/GBbjmfnNk3B iYdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:date:message-id :autocrypt:from:references:cc:to:dkim-signature:subject; bh=PHt1+Y+M9O7RcuFbfb1lsOWaqXA0PJHKNi0LYmRfAEk=; b=azsVVOR6VE/Sb7JHe2BFeeMNXPCfD6hSmDsTVmctZyg5fvCN3SkwP7O3RpsyAfpJw2 UHjrZ1+eZFBXHtHAV/Ztdo/cFX1maYE4gpz+9UkVI7eVzbwdo634tGS4XESR8+rJHj2B j3bbRUETdetc79g8QdrfPv3TfFmrLebfvLeFWvqguG6WngiIgLnKO6fTTyfbejKWc576 nNFUJtNFjrcPlhwpiL45dYZrVJuKW47zIXAq+ctg/QAEc6j0pu7A28ZSxXccWKCrasaU jj5zQCRmQOlmXOPAR4/TbHlDcIM5iNfSQsSuJgAJ/OqyvRRQIc35kAiLfcrRq/0lqoYX hrSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@systemli.org header.s=default header.b=veaxFPxM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=systemli.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r3si501207edx.238.2020.10.13.12.42.16; Tue, 13 Oct 2020 12:42:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@systemli.org header.s=default header.b=veaxFPxM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=systemli.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727788AbgJMTIF (ORCPT + 99 others); Tue, 13 Oct 2020 15:08:05 -0400 Received: from mail1.systemli.org ([192.68.11.209]:34344 "EHLO mail1.systemli.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727033AbgJMTIE (ORCPT ); Tue, 13 Oct 2020 15:08:04 -0400 X-Greylist: delayed 558 seconds by postgrey-1.27 at vger.kernel.org; Tue, 13 Oct 2020 15:08:02 EDT Subject: Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systemli.org; s=default; t=1602615523; bh=PHt1+Y+M9O7RcuFbfb1lsOWaqXA0PJHKNi0LYmRfAEk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=veaxFPxMCSHBFnG+4P7/Wl8dPZNMcwsB8JgF4VP2mgcfzHyLkdHq/alL8N4s2z/NS mPJJvCzZtsljZefrPAtIyGYpyFSmiJ7/wfut5wnjMhGg3qFdQEOFdO5dXzLTYmLR7F 0UAYcoGsk9IAMYBilLzOeeINGlsGen9RH/W0nzZieyxcR4/p6DzCMxXnIx2AlOikhM ouoYD1lK3gLR0NefMjXuAIMhl8ccv4dFIv07RnO23r/S0hedHHILh3SXaQgRVomSA9 WGTSiMrKv9zs0BzOVEtT1gGeQIdxvxceJADF4Heaqc0Vlyv+BB9kEM8uCG7KO/Rf3g GF2JFb8M+AdYQ== To: Kleber Sacilotto de Souza , netdev@vger.kernel.org Cc: Gerrit Renker , "David S. Miller" , Jakub Kicinski , Thadeu Lima de Souza Cascardo , "Gustavo A. R. Silva" , "Alexander A. Klimov" , Kees Cook , Eric Dumazet , Alexey Kodanev , dccp@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201013171849.236025-1-kleber.souza@canonical.com> <20201013171849.236025-2-kleber.souza@canonical.com> From: Richard Sailer Autocrypt: addr=richard_siegfried@systemli.org; prefer-encrypt=mutual; keydata= mQENBE3hr2UBCACos1E12camcYIlpe25jaqwu+ATrfuFcCIPsLmff7whzxClsaC78lsxQ3jD 4MIlOpkIBWJvc4sziai1P/CrafvM0DTuUasCv+mQpup6cFMWy1JmDtJ8X0Ccy/PH83e9Yjnv xJu0NhoQAqMZrVmXx4Q7DKcgpvkk9Oyd5u6ocfdb2GhF0Bxa7GySZyYOc4rQvduRLOdNMbnS 6SM+cTAhMOHtoqKWCP4EogXKALg6LDFcx8yUoMzLRy/YXsnWa1/WayG8Zr6kX84VKhTGUrdG Pw4Zg1cQ6vqwMZ4RwaR/9RWK2WnYr7XyOTDBgmCix5c5lu+GeLqUYUIPTvdQ7Xgwx0UhABEB AAG0OVJpY2hhcmQgU2llZ2ZyaWVkIFNhaWxlciA8cmljaGFyZF9zaWVnZnJpZWRAc3lzdGVt bGkub3JnPokBVwQTAQgAQQIbIwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAIZARYhBAYAIbmK zp5fVAuyN/ZBOcwFm+HhBQJanueLBQkSYNKmAAoJEPZBOcwFm+Hh+ugH/2P0yClrZkkMK5y2 L389qNPlF8i1H77S4NE9zxiHI38jnIFLqjD4F+KzGAXNmOXCw+QYqLL+TmsuGY+5LOLtp/M4 lG6ajVC1JCcF2+bQrDc11g7AG7A+rySX5JpqSFO7ARfLTs3iW1DoyLN7lBUtL9dV+yx9mRUv fx/TcB9ItPhK4rtJuWy3yg6SNBZzkgc0zsCyIkJ4dEtdEW6IgW6Qk242kMVya8fytM02EwEM vBTdca/duCO2tEComPeF+8WExM+BfQ+6o3kpqRsOR6Ek6wDsnalFHy8NHaicbEy7qjybGOKZ IdvzAyAhsmpu+5ltOfQWViNBseqRk1H9ikuTKTq5AQ0ETeGvZQEIANRmPSJX9qVU+Hi74uvD /LYC3wPm5kCAS0Q5jT3AC5cisu8z92b/Bt8DRKwwpu4esZisQu3RSFvnmkrllkuokSAVKxXo bZG2yTq+qecrvKtVH99lA0leiy5TdcJdmhJvkcQv7kvIgKYdXSW1BAhUbtX827IGAW1LCvJL gKqox3Ftxpi5pf/gVh7NFXU/7n6Nr3NGi5havoReeIy8iVKGFjyCFN67vlyzaTV6yTUIdrko StTJJ8c7ECjJSkCW34lj8mR0y9qCRK5gIZURf3jjMQBDuDvHO0XQ4mog6/oOov4vJRyNMhWT 2b0LG5CFJeOQTQVgfaT1MckluRBvYMZAOmkAEQEAAYkBPAQYAQIAJgIbDBYhBAYAIbmKzp5f VAuyN/ZBOcwFm+HhBQJanueQBQkSYNKrAAoJEPZBOcwFm+HhrCAH/2doMkTKWrIzKmBidxOR +hvqJfBB4GvoHBsQoqWj85DtgvE5jKc11FYzSDzQjmMKIIBwaOjjrQ8QyXm2CYJlx7/GiEJc F3QNa5q3GBgiyZ0h78b2Lbu/sBhaCFSXHfnriRGvIXqsxyPMllqb+LBRy56ed97OQBQX8nFI umdUMtt8EFK2SM0KYY1V0COcYqGHMRUiVosTV1aVwoLm2SXsB9jicPUaQbRgsPfglTn00wnl fhJ8bAO800MtG+LW6pzP+6EZPvnHhKBS7Xbl6bn6r2OW32T7TeFg0RJbpE/MW1gY0NjgmtWj vdhuvK9nHCRL2O/xLofm9aoELUaXGHoxMn4= Message-ID: <0de6cc66-8825-6631-843e-68fc9e2c1517@systemli.org> Date: Tue, 13 Oct 2020 20:58:34 +0200 MIME-Version: 1.0 In-Reply-To: <20201013171849.236025-2-kleber.souza@canonical.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KHVaNnR0CtdkaZCgAsBVhWbXcrEqCZBOz" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KHVaNnR0CtdkaZCgAsBVhWbXcrEqCZBOz Content-Type: multipart/mixed; boundary="dfjn9C3XkBZ9ZjEm6mKvr0DLGL7w3liEv"; protected-headers="v1" From: Richard Sailer To: Kleber Sacilotto de Souza , netdev@vger.kernel.org Cc: Gerrit Renker , "David S. Miller" , Jakub Kicinski , Thadeu Lima de Souza Cascardo , "Gustavo A. R. Silva" , "Alexander A. Klimov" , Kees Cook , Eric Dumazet , Alexey Kodanev , dccp@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <0de6cc66-8825-6631-843e-68fc9e2c1517@systemli.org> Subject: Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock References: <20201013171849.236025-1-kleber.souza@canonical.com> <20201013171849.236025-2-kleber.souza@canonical.com> In-Reply-To: <20201013171849.236025-2-kleber.souza@canonical.com> --dfjn9C3XkBZ9ZjEm6mKvr0DLGL7w3liEv Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 13/10/2020 19:18, Kleber Sacilotto de Souza wrote: > From: Thadeu Lima de Souza Cascardo >=20 > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reas= on > del_timer_sync can't be used is because this relies on keeping a refere= nce > to struct sock. But as we keep a pointer to dccps_hc_tx_ccid and free t= hat > during disconnect, the timer should really belong to struct dccp_sock. >=20 > This addresses CVE-2020-16119. >=20 > Fixes: 839a6094140a (net: dccp: Convert timers to use timer_setup()) > Signed-off-by: Thadeu Lima de Souza Cascardo > Signed-off-by: Kleber Sacilotto de Souza Acked-bd: Richard Sailer Implementation and concept looks fine to me --dfjn9C3XkBZ9ZjEm6mKvr0DLGL7w3liEv-- --KHVaNnR0CtdkaZCgAsBVhWbXcrEqCZBOz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEBgAhuYrOnl9UC7I39kE5zAWb4eEFAl+F+N8ACgkQ9kE5zAWb 4eH0WQf/UWTTCBzTGhg11Zme2bEngbGDoD/xYPUZ8TvPD7cXCoq0WGSVG9yqaTc1 vXwH1+jvNoJHQ7NvXOoUEe1fGmgNVdFNIw5RzEy/9Oi8rukTpvjloFCproonNeNs mVAS95hbRHKho+NG+MmtR3yuH52SLtgtCdn64lJjAaNeX1oWGbUNwSK7TNY9Wrjj ubteuQz3mFOFyca/V4xJZU58jz5Ikp420w/UdQGGtmUf133L3rZxDrT0ilKkZEiS eeDfKRDQlkBbCvOlkuG6dER/nPUF0in8n1Ci6Jycwk2gsMIKSt3La178e3di6NHB zdVms9QK+dASFjYym7NaXmjTjXS+cQ== =WF3A -----END PGP SIGNATURE----- --KHVaNnR0CtdkaZCgAsBVhWbXcrEqCZBOz--