Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp5056505pxu; Tue, 13 Oct 2020 13:45:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9ZEON8VM7DXD0p/KQQhesOiRB1wAA/PDk02LFjG1TQc6+Ei1HHsUx5y1G3mqxtpXLljoy X-Received: by 2002:a17:906:590d:: with SMTP id h13mr1658069ejq.226.1602621913360; Tue, 13 Oct 2020 13:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602621913; cv=none; d=google.com; s=arc-20160816; b=tSxLqC1j5gbcgrOVs24l95NrgXVLwCuL5a9XK/xx2WIPEemJxF5//OOqZ5GtOrp0cZ FD4lkMpIi+IgyUDdznEMYMOrf9jB3ZvwYsDfEFGJ1SdILMYWnMWq3afirkyia48+Aq2T pSCxAp4BeRCvmAMr++lyjaT4VFxCOeo2UOqcAsGWQ+G7MIlLIRULxCpDS4FFbZl4u3jX OgfRF+noPHf5Q4qId/WF4NrexACCx74XQAaaW3UWUKZPZFdggM11BZt1D/a5AkR1cf4A 8TkZjqI9c0PxR/jpekDNTK2lZqARgnAyq2KeOOIoqVuxfA4oC3rZqV6RxgCVWcZpyEx1 swwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :references:to:from:subject:dkim-filter; bh=pCOGjz5/vLZVcrcWW/4UUI++05xrMSB3nvXXsAH3vTk=; b=BQVO5YqFlb7K5foD81Z7kzZ3ngzkWHeVTJr+zKnkCXo3Vhb0UGrsfdOp+PfMrqoIeY FBWjEjUZMFBmu0demQH1/pDb49ErS1tRKNWxSxu9x5LIGOknLWxR21qKtwQ+w0CXNP7/ DcWT5TQfmKFr15QqkTxYK5jTQYbQfaqLhnWlErzg4WkF4NdZE/GPf2akZCgDM69bh2JP WWSgzgartWJAv9yuE5y4R3H8vY+NRQEDsUxCX0qrJOabNXDh2RiAheJVeZ7RP+7Sqxep MZFVTKc2VKRzsOrGhR0ZO9Lql08YtzjJhQwmjEeVU7ixR70pi1OWSTqVoVX3HN5qPs00 bbTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=omprussia.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c14si615513edw.305.2020.10.13.13.44.51; Tue, 13 Oct 2020 13:45:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=omprussia.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727397AbgJMUnN (ORCPT + 99 others); Tue, 13 Oct 2020 16:43:13 -0400 Received: from mxout04.lancloud.ru ([89.108.124.63]:47528 "EHLO mxout04.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbgJMUnM (ORCPT ); Tue, 13 Oct 2020 16:43:12 -0400 X-Greylist: delayed 539 seconds by postgrey-1.27 at vger.kernel.org; Tue, 13 Oct 2020 16:43:11 EDT Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru C99A920510BA Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: [PATCH 2/2] module: unindent comments in module_sig_check() From: Sergey Shtylyov To: Jessica Yu , References: <789a4e5c-8efd-bb1c-86e2-eed8b2b7b0af@omprussia.ru> Organization: Open Mobile Platform, LLC Message-ID: <24fb12d3-aefb-a66e-524d-107bce8f8c68@omprussia.ru> Date: Tue, 13 Oct 2020 23:35:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <789a4e5c-8efd-bb1c-86e2-eed8b2b7b0af@omprussia.ru> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [213.87.131.195] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1908.lancloud.ru (fd00:f066::208) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The way the comments in the *switch* statement in module_sig_check() are indented, it may seem they refer to the statements above them, not below. Align the comments with the *case* and *default* labels below them, fixing the comment style and adding article/dash, while at it... Signed-off-by: Sergey Shtylyov --- kernel/module.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) Index: linux/kernel/module.c =================================================================== --- linux.orig/kernel/module.c +++ linux/kernel/module.c @@ -2901,10 +2901,11 @@ static int module_sig_check(struct load_ info->sig_ok = true; return 0; - /* We don't permit modules to be loaded into trusted kernels - * without a valid signature on them, but if we're not - * enforcing, certain errors are non-fatal. - */ + /* + * We don't permit modules to be loaded into the trusted kernels + * without a valid signature on them, but if we're not enforcing, + * certain errors are non-fatal. + */ case -ENODATA: reason = "no signature"; goto decide; @@ -2922,10 +2923,10 @@ static int module_sig_check(struct load_ return security_locked_down(LOCKDOWN_MODULE_SIGNATURE); - /* All other errors are fatal, including nomem, unparseable - * signatures and signature check failures - even if signatures - * aren't required. - */ + /* + * All other errors are fatal, including nomem, unparseable signatures + * and signature check failures -- even if signatures aren't required. + */ default: return err; }