Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 2/2] ovl: introduce new "uuid=off" option for inodes
 index feature
To:     Miklos Szeredi <miklos@szeredi.hu>
Cc:     Amir Goldstein <amir73il@gmail.com>,
        Vivek Goyal <vgoyal@redhat.com>,
        overlayfs <linux-unionfs@vger.kernel.org>,
        linux-kernel@vger.kernel.org
References: <20200925083507.13603-1-ptikhomirov@virtuozzo.com>
 <20200925083507.13603-3-ptikhomirov@virtuozzo.com>
 <CAJfpegvgmnWrmsACuWe_hYCfVm2r0Ltv0C+sN+3T1DBMzrGE9w@mail.gmail.com>
From:   Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Message-ID: <abac619b-dec4-8179-cb59-52c8f14422a1@virtuozzo.com>
Date:   Tue, 13 Oct 2020 16:54:38 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
In-Reply-To: <CAJfpegvgmnWrmsACuWe_hYCfVm2r0Ltv0C+sN+3T1DBMzrGE9w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.192] (46.39.230.109) by AM0PR01CA0144.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.22 via Frontend Transport; Tue, 13 Oct 2020 13:54:39 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3860706d-1435-4629-96e7-08d86f7f8771
X-MS-TrafficTypeDiagnostic: AS8PR08MB5926:
X-Microsoft-Antispam-PRVS: <AS8PR08MB592695A97454895C9DAF400DB7040@AS8PR08MB5926.eurprd08.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 55JLPyElBzMB3MM4ZihTHpYtwdBdio8q5dPPo34HLm5GR9fpTbE/4QiAHJKlONPWwqGDSgmavpK7p2WELsJ4W1SlM+QlZ93D4hCLyY9swosWLrKuuoH+vNQRE+XK1BhcYSg2nEXe/Rlj1bskd0XZ5j9t8wnJ3MeicxaJKr3ak1PuzUReVFdW3X2GUGP5OZK73bxFrIHTZHDZ1nUg2ylcik07iod4kh+XcAf4LpraA8IXagkmezthBg6pHXCUOVnB5hU2YQhwm/w9auWnb6kQ5UQGy/kUiqf4Ty6EDwU3P4+F8+ySPSqu963oUT6j1l47ayS/Z2MDp3UMU1Vk8EdZQ1YZES/+qokNREHAmMGkKgHcIUEUzxBPVEPWiTTy1Qcp
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB4756.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(366004)(39840400004)(136003)(26005)(66556008)(2906002)(478600001)(6916009)(16526019)(186003)(66946007)(53546011)(5660300002)(66476007)(6486002)(4326008)(36756003)(316002)(86362001)(8676002)(54906003)(31696002)(956004)(16576012)(2616005)(31686004)(8936002)(52116002)(43740500002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: o7UhRrgPytxc6Yska8JLj5qfPDGGe4hJ0bCfM1J85faPpm0VsTpWUtTaCI0lifOCiHUzB/EqD4MGL5tAJjT8u7QtE9GLcfcnOj7izJ6UFggBStrDtVV1psnWvZVV2AqPJRKwdQBmf6stf3w2o6wlzFCIZQMPWTe9vaU+VMDligBXU2JHc4fyVOFoE82elpUI83ZeC3CAcVcIncLaVHOYcukYeqMeZ1+5xbi+6zgk3YzmSfnEHU+qqtw9x3zH+ESC1V7KfTGRbuIdZ3EXgeqLHr9WeaDpoBf1d8pucCioARMlZJoRoxOgq1c9AEmvKIERQRB8xpnXktFqpp8rnTFTqXtkDU3abv9fH+hfFJVixDS2sAU/UvzuFSDOZW3rLWN0ObkqhxoR3zUXiyYVhh3BZOc/rTmTv3gQqEOShPnFP9dB3GM0crqK4xkIa9BP2L0ErT99FGxhbpVHP3mxUOH/2ICInWCuUgXQUcKX5kHhD4i0C8k9f5Hx3eMC6C4BdNO8tFJAgZflV8+855wm7w7C7MpGAs/SB4TiMM30umO7o1Gp8pu9SmFK7RCxX+o4TVocceLgS+QNLxBKkvhcfSnRs7eCqW2dAbeKwHI0PbUs4fwodWbHx5GYkIcePPC+7x9b6Gi/SUOlyplvbNcFmFCHjA==
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3860706d-1435-4629-96e7-08d86f7f8771
X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB4756.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2020 13:54:39.9111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N5ay7yKhIZFn8xWvGXHVW2DTW9BkE4YHMj/exoCf9ru+uba2UG5Xbbin2dzSrWdS6BV4BC8FkKfTxbw9BQvDA5VxUn6cZW+BqvjmKmvjC00=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5926
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/6/20 6:13 PM, Miklos Szeredi wrote:
> On Fri, Sep 25, 2020 at 10:35 AM Pavel Tikhomirov
> <ptikhomirov@virtuozzo.com> wrote:
> 
>> Note: In our (Virtuozzo) use case users inside a container can create
>> "regular" overlayfs mounts without any "index=" option, but we still
>> want to migrate this containers with CRIU so we set "index=on" as kernel
>> default so that all the container overlayfs mounts get support of file
>> handles automatically. With "uuid=off" we want the same thing (to be
>> able to "copy" container with uuid change) - we would set kernel default
>> so that all the container overlayfs mounts get "uuid=off" automatically.
> 
> I'm not sure I buy that argument for a kernel option.   It should
> rather be a "container" option in that case, but AFAIK the kernel
> doesn't have a concept of a container.  I think this needs to be
> discussed on the relevant mailing lists.
> 
> As of now mainline kernel doesn't support unprivileged overlay mounts,
> so I guess this is not an issue.  Let's just merge this without the
> kernel and the module options.

Virtuozzo kernel does have a "container" concept and we do have 
unprivileged overlay mounts to support docker inside Virtuozzo 
containers. We don't face any major issues with it. But you are right 
it's not mainstream.

Probably a normal user of mainstream kernel also might want to set 
index=on+uuid=off by default, so that all their docker containters 
automatically support inotifies and survive backing disk uuid change 
automaticaly.

I will prepare next patchset version without default.

> 
> Thanks,
> Miklos
> 

-- 
Best regards, Tikhomirov Pavel
Software Developer, Virtuozzo.