Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201013055454.52634-1-laoar.shao@gmail.com> <20201013090511.1f2f71f6@gandalf.local.home>
In-Reply-To: <20201013090511.1f2f71f6@gandalf.local.home>
From:   Yafang Shao <laoar.shao@gmail.com>
Date:   Tue, 13 Oct 2020 22:48:52 +0800
Message-ID: <CALOAHbBb2D+iYHfaXaE+Nux7EtxwLW-cT-BXw2=o_2nfMYakmw@mail.gmail.com>
Subject: Re: [PATCH] tracing: add tgid into common field
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Ingo Molnar <mingo@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 13, 2020 at 9:05 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 13 Oct 2020 13:54:54 +0800
> Yafang Shao <laoar.shao@gmail.com> wrote:
>
> > --- a/include/linux/trace_events.h
> > +++ b/include/linux/trace_events.h
> > @@ -67,6 +67,7 @@ struct trace_entry {
> >       unsigned char           flags;
> >       unsigned char           preempt_count;
> >       int                     pid;
> > +     int                     tgid;
> >  };
> >
>
> Sorry, this adds another 4 bytes to *every* event, if you want it to or
> not. I'd rather have some ways to remove fields from this header, and not
> add more to it.
>
> I can't take this patch.
>

Right, that is an overhead. I will think about some ways to avoid adding it.


-- 
Thanks
Yafang