Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Oct 2020 13:22:20 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 03/15] perf data: open data directory in read access
 mode
Message-ID: <20201013162220.GK1063281@kernel.org>
References: <810f3a69-0004-9dff-a911-b7ff97220ae0@linux.intel.com>
 <9ac7f12e-f5a4-dd91-a19a-bb7e5be27636@linux.intel.com>
 <20201012160339.GB466880@tassilo.jf.intel.com>
 <49bfe810-f1cc-b1c6-67d3-b0a746552fd6@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49bfe810-f1cc-b1c6-67d3-b0a746552fd6@linux.intel.com>
Precedence: bulk

Em Mon, Oct 12, 2020 at 07:52:33PM +0300, Alexey Budankov escreveu:
> 
> On 12.10.2020 19:03, Andi Kleen wrote:
> > On Mon, Oct 12, 2020 at 11:55:07AM +0300, Alexey Budankov wrote:
> >>
> >> Open files located at data directory in case of read access mode.
> > 
> > Need some rationale. Is this a bug fix? Did the case not matter
> > before?
> 
> This is not a bug fix. The case didn't matter before.

In such cases can you please write a paragraph explaining why it didn't
matter before and now it is required?

- Arnaldo
 
 > 
> >>
> >> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
> >> ---
> >>  tools/perf/util/data.c | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> >> index c47aa34fdc0a..6ad61ac6ba67 100644
> >> --- a/tools/perf/util/data.c
> >> +++ b/tools/perf/util/data.c
> >> @@ -321,6 +321,10 @@ static int open_dir(struct perf_data *data)
> >>  		return -1;
> >>  
> >>  	ret = open_file(data);
> >> +	if (!ret && perf_data__is_dir(data)) {
> >> +		if (perf_data__is_read(data))
> >> +			ret = perf_data__open_dir(data);
> >> +	}
> >>  
> >>  	/* Cleanup whatever we managed to create so far. */
> >>  	if (ret && perf_data__is_write(data))
> >> -- 
> >> 2.24.1
> 
> Alexei
> 

-- 

- Arnaldo