Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201013135913.29059-1-georgi.djakov@linaro.org>
In-Reply-To: <20201013135913.29059-1-georgi.djakov@linaro.org>
From:   Saravana Kannan <saravanak@google.com>
Date:   Tue, 13 Oct 2020 11:04:42 -0700
Message-ID: <CAGETcx8JWztwy8LevoT30NrhioxF+L9XF7ezxJQ7NscL5=+Xiw@mail.gmail.com>
Subject: Re: [PATCH 1/3] interconnect: Aggregate before setting initial bandwidth
To:     Georgi Djakov <georgi.djakov@linaro.org>
Cc:     Linux PM <linux-pm@vger.kernel.org>,
        Mike Tipton <mdtipton@codeaurora.org>, okukatla@codeaurora.org,
        Sibi Sankar <sibis@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 13, 2020 at 6:59 AM Georgi Djakov <georgi.djakov@linaro.org> wrote:
>
> When setting the initial bandwidth, make sure to call the aggregate()
> function (if such is implemented for the current provider), to handle
> cases when data needs to be aggregated first.
>
> Fixes: b1d681d8d324 ("interconnect: Add sync state support")
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
>  drivers/interconnect/core.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index eea47b4c84aa..974a66725d09 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -971,6 +971,9 @@ void icc_node_add(struct icc_node *node, struct icc_provider *provider)
>         }
>         node->avg_bw = node->init_avg;
>         node->peak_bw = node->init_peak;
> +       if (provider->aggregate)
> +               provider->aggregate(node, 0, node->init_avg, node->init_peak,
> +                                   &node->avg_bw, &node->peak_bw);
>         provider->set(node, node);
>         node->avg_bw = 0;
>         node->peak_bw = 0;

Acked-by: Saravana Kannan <saravanak@google.com>

-Saravana