Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp150323pxu; Tue, 13 Oct 2020 19:47:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQyEDWZE71UgcOd4DUyfgrJHSH0Gd3sgQ8XISFx8tkzwPRTplgv4Mk+3fhvqts6kUsFLhk X-Received: by 2002:a17:907:20b2:: with SMTP id pw18mr2899120ejb.159.1602643621675; Tue, 13 Oct 2020 19:47:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602643621; cv=none; d=google.com; s=arc-20160816; b=tKnvPipO1SBvqPI+cbE/KIBoMddizdnf9kDL5bG6iL34wbjZZqFFzqRl0c10tjwPCs uZXjhVINi/+whYyton4W8nOVtjwwQv3EETRkJ5tVWNW2pTvtU3wOo/Ys6GiYEwtXjsCc deYY+RBwXzhwXYdtVWtoo59QyTSsNDbpPJdo2NqL8dqH1L48PTNiaf5csDjHYasIXZ7A Ki+CGuiJxeBHiDZbVxxLTJ4IcMJE+wColDOSUyewe0l7OpzwIZrlj7mDVQI/3b1PWmr5 KDOaUab9vNmTnX7d2LI6jQxn6aM6VSBkqO2ya8QGtBg+72GFYxGfpmOXKT6mCsHo3XmA DLyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:sender:dkim-signature; bh=8wS/OhEkiOS3keXiGTDs7Y3EitxUywvOHPNnihsdSyE=; b=K93KDzzDH4mCYwssorhQExODSoH++nKfhKxynIvZ+vJb+ZKO2AtNumnxOUlP9gRonR pt1+/VJ48wR65tMFYVpy6Tcf2fhB6/WVzDYcJX4WTAm6rv2SYQZ4aEGE2vGxJVvld2xG 8NNg1CqMcep55tNCMhnZ6DbLYzQN37LA5fl+UvVnIYxxTj+lyuuf57AdgYFHO9qtHvAs JlisWF+qkkX0u0X5ExNRuE4DIX639H3n09qxzBXE0RpzmKECK1OcER0/N1E1kZ+gMWyT TiKpOLMwlTQnDUkZ0eXhJrfuDsfRAwuAdnppRyAbxMHatJ67baFPwViucohTsKPfLxfW qF1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=t0F+G1O5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si1465409ejm.716.2020.10.13.19.46.37; Tue, 13 Oct 2020 19:47:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=t0F+G1O5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731158AbgJMSh7 (ORCPT + 99 others); Tue, 13 Oct 2020 14:37:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729085AbgJMSh6 (ORCPT ); Tue, 13 Oct 2020 14:37:58 -0400 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D51EC0613D0 for ; Tue, 13 Oct 2020 11:37:57 -0700 (PDT) Received: by mail-oi1-x244.google.com with SMTP id q136so421579oic.8 for ; Tue, 13 Oct 2020 11:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8wS/OhEkiOS3keXiGTDs7Y3EitxUywvOHPNnihsdSyE=; b=t0F+G1O57UeI6bVpdwwjjwQhbKg5SBBNcbIjsuCgtfQyj6d8rq1BA8rIz7ecaA71gc T+IiHEtF2kw2edN5eOkaWaVo+yV5In0UaemYwBdjscCgWg02vLKA8ZvaYhVH1Jw++eOt /sNPo4wVn1J+l+bRRXfWGk4pHrLhxEoRO3+A3qVvDzYUb+uvya2DmTzXJM0KI0fO2Mpb UptCNBv+7ZuqMnEHb/0qs/9RRmkwAdHT+N3fQ3mfml0etfTfgcEE2CcyszhMK7RaoqAG lJQC7yVzxzLAfFz+nYX6Tg50jYOKH6mNB8adN36wGC6EJiZ3k4d67MXZQ0Ed30Ssu62v GlNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8wS/OhEkiOS3keXiGTDs7Y3EitxUywvOHPNnihsdSyE=; b=FMCvJp5YKKdu7pnpLGanPfn5IjV0wkF2ioSoQqPoA/zS8ErQF8FwctDlvldzTN8k48 y10mS8Vd+04THf8pfZBlwh/qG6+gx3zMfM9bZV/S3jiipxSBMcPDkwbBZkktHb8o9oKJ TZHQM5Opp9NfWckKdBUk7rn4UJNS8bTM+UYSGCBENfYjv6oErDdR6bgtRcCB7MHzuSul 5Bcat3aIHSTuqHaf1CU1cJ4y5JDIcnJKVhRelwRAdmX1AcEMwIP+vFJaWgyt2UNKC0b+ vLILLN7xU0vtmBVlDfHmy9aj7mXzGNaLfWYLUOVShCL4KV5/lNtU8PbG7u5DGYqWnVCP Yizw== X-Gm-Message-State: AOAM533qLD9f6qaTGwU5kv+t5jdIK4WtM34WF8uB6B3RdB5uGNFeUqjg ZtBN/j6Os0vHmY66T2E5/D8= X-Received: by 2002:a05:6808:217:: with SMTP id l23mr711073oie.120.1602614276614; Tue, 13 Oct 2020 11:37:56 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n185sm217550oia.28.2020.10.13.11.37.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Oct 2020 11:37:56 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228 To: Alex Qiu , Grant Peltier , Linux Kernel Mailing List , Adam Vaughn , Guenter Roeck Cc: Jason Ling References: From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <0e325e4f-bb7c-f2d3-1f16-34a89397df39@roeck-us.net> Date: Tue, 13 Oct 2020 11:37:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/20 11:18 AM, Alex Qiu wrote: > (Intercepting the email thread...) > > Hi Grant, > > Looks like you made a typo in your patch: > >> + case raa_dmpvr2_2rail_nontc: >> + info->func[0] &= ~PMBUS_HAVE_TEMP; >> + info->func[1] &= ~PMBUS_HAVE_TEMP; >> + fallthrough; > > Did you mean "/* fallthrough */" instead of "fallthrough;"? > No, that is the fancy new way to indicate fallthrough in the kernel. It is converted to either __attribute__((__fallthrough__)) or to do {} while (0) in include/linux/compiler_attributes.h. Guenter