Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp237290pxu; Tue, 13 Oct 2020 23:08:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDBLomgfDcZQAU0ATogY++U2k1XpSgY70VllmnaS+wOe+wV1mqCJ672e7ZjF08gc3kgpmk X-Received: by 2002:aa7:cad6:: with SMTP id l22mr3485390edt.229.1602655688285; Tue, 13 Oct 2020 23:08:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602655688; cv=none; d=google.com; s=arc-20160816; b=SaiMYtt5EPfEugp5mgRYmL6ZJo87KwjsN/th+bXegUivX+LlnQyl6jLove4u3d5bcB J0z/zYJCb1jJ5kqTG5UHBnZ0V82G0DDy50OH/94W5u5YQdcR9SdqUCdZeW+N03F8uS7k AccatQDwr9aJ1r9lYNb6DExrr/y0fTlgsb44DgtSqrub77iO0SDHNCoSZXLlhJyHhprM ez9JVcrcUsZC6/FsKW9TGiLPvy9cv++8jibPJNW+MG9jjebZu1LAB5uTvWbLvnITeuJc LJxDNOP7d/NT+mII3rS9VBNikyWOYtr4XlB8rh+3YJivx5m8Xc3VuADNWuZsQLtWveKG hSeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=UJlIe/Y1UnEj2EVL0fmpbETtgVopdOZvwXEzD5BF4c8=; b=mKG0EYHRptgEtBel9//eK3YYC/xRw550Z2K9NQVX8ltiFx7Gpmw1rypoiWKV8x8z0M ZupX6Gow8IB49WWhsJjBg0RLOFz37ImY4LLEAL5g/4psSs3HDfhjfvaqYu9kd/imPeV4 DzymELpiFjkDrSvYy4ix5ohjHGJIF1T+JCkbmOVk0KZCQjg2xbbAisrFrixzrh/1HNdK K1QDoZXUCosu/eqVGzVj1/KR5d92JPwcoZ8zo4tS+SbCq0S+0DtNovmNB+s8/HcpQarU lprErIcino3AcOSQ//AyXhVGAUYef2MTN+4Q77SHWMfL3t8pS67JOs6LsX6nEw2wmOBu qRTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=pOMe11T9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m20si1503532edq.33.2020.10.13.23.07.23; Tue, 13 Oct 2020 23:08:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=pOMe11T9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727369AbgJMSDR (ORCPT + 99 others); Tue, 13 Oct 2020 14:03:17 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:56464 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbgJMSDR (ORCPT ); Tue, 13 Oct 2020 14:03:17 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09DI3FB6092528; Tue, 13 Oct 2020 13:03:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1602612195; bh=UJlIe/Y1UnEj2EVL0fmpbETtgVopdOZvwXEzD5BF4c8=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=pOMe11T9VGOqTRis3/P3Bwa5riOG0rlluSij32nhFZm0QRgRfzwSvirnKUn3LOmHS O372Kyq/fW5guNBiDxLyo2FfhlzgaHy1/2NpcD39yVwGg8/wQY6W2iZvjJ1BrZnZ8J fC6mBev8/H+trZCbg/Orpk3pcegOgX5HdTLkoDt0= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09DI3F4w081843 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 13 Oct 2020 13:03:15 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 13 Oct 2020 13:03:14 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 13 Oct 2020 13:03:14 -0500 Received: from [10.250.67.63] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09DI3Dqa005493; Tue, 13 Oct 2020 13:03:14 -0500 Subject: Re: [PATCH] power: supply: bq25980: Fix uninitialized wd_reg_val and overrun To: CC: , , , References: <20201009121205.28178-1-dmurphy@ti.com> From: Dan Murphy Message-ID: Date: Tue, 13 Oct 2020 13:03:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201009121205.28178-1-dmurphy@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian On 10/9/20 7:12 AM, Dan Murphy wrote: > Fix the issue when 'i' is equal to array size then array index over > runs the array when checking for the watch dog value. > > This also fixes the uninitialized wd_reg_val if the for..loop was not > successful in finding an appropriate match. Might want to pull this into next as well this is a 0-day bug fix Dan