Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp258610pxu; Tue, 13 Oct 2020 23:56:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwn2B4sE9kzzx5F7m+zHa6v8gPaau6lonYyetfv4i/ZIeqTZaSKgS8qC30HBr4NE8OK6lzo X-Received: by 2002:aa7:d4c6:: with SMTP id t6mr3581465edr.372.1602658573016; Tue, 13 Oct 2020 23:56:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602658573; cv=none; d=google.com; s=arc-20160816; b=QAWpCB1x7zp5reuTW2xrTfxmnpUubiZajYYEqnOGFSDwl5EUFh01EaPsJZJDERz5a7 3SxKb6MUW6oc+Qqqdgu3vMd2+ed8gnbg54okgVewQoOCOZJOTQs6y8Jc+ISOTOqPWBsD BS1RN7uMONTC08wYvK6vKCaECOrAaRqywL/VsCIB+b4Vx9igHm9PcOy/IWqbUHd8aU/7 wpRbmMMQjt7bFqNlLLaJWwXRXBgv/tgyI4YBlZTo/LlBWoE/GL6QQ5a7B2ADHfEzPrjB IGGH4uBXIX0nxpTAF+v/F8+6yycEXzttZh49Cr209K4yfRUwLN/BO8/WGpX0aOb+57I8 9uiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mHiysqJkcsaVHBb3pBlRG17I+HxL8BTZ42A6v8iuD/Y=; b=MIhrIksTuZXoDtd1yzbRiDyaAgsKaGpTBQ9x6WJiEovPUG/tMylaVoDwvTsQ+1o3Ou j/2gp/WCfYzy006hesZiywA6MYye5ig+XnvRPme442vqO5RAqh7Kf4pmzxu+8LMWbsDh HvfrP3FqQi13CEbYZQo9RUlo2kTM7c8EeXHE6536ii8KFAm0fTjAdp2Rrh7lJczmiyu3 K7kKXCKkY8FeEiVgM0H0fZbgaxCTw4hywxCtBOsoR84OCGHNcnbDiPKEYvBxMAlGpSkJ cSI96Am29dy444soRwWHAAgT3k2RAjnBFytjLkVOMXuVmSa4/J9H/kcQUiIUtycDH0tc iNXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="RwfQ/Kkh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si1764390ejf.271.2020.10.13.23.55.51; Tue, 13 Oct 2020 23:56:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="RwfQ/Kkh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728420AbgJMVkO (ORCPT + 99 others); Tue, 13 Oct 2020 17:40:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:50614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726652AbgJMVkN (ORCPT ); Tue, 13 Oct 2020 17:40:13 -0400 Received: from earth.universe (unknown [185.213.155.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC58A21582; Tue, 13 Oct 2020 21:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602625213; bh=mHiysqJkcsaVHBb3pBlRG17I+HxL8BTZ42A6v8iuD/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RwfQ/KkhOQBTWfMQuvnvf1aUYSygb3PDm+bbzE3nPXUNlBm8mHKVzzpYL3xF5u1c9 lvWVH2+higZrwdskAgYH1O3Jtop5lvdIQPhhSUkBzNucgVwpHdpbnjOT/cEPrNOB1y 37xxab+5k7bLkIqPLISASLrVTCq7Dgb6Fo3sAfbU= Received: by earth.universe (Postfix, from userid 1000) id D282F3C0C87; Tue, 13 Oct 2020 23:40:10 +0200 (CEST) Date: Tue, 13 Oct 2020 23:40:10 +0200 From: Sebastian Reichel To: Dan Murphy Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: supply: bq25980: Fix uninitialized wd_reg_val and overrun Message-ID: <20201013214010.2qulyhqo2x6lebwl@earth.universe> References: <20201009121205.28178-1-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kitil4vbe2z42uf6" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kitil4vbe2z42uf6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Dan, On Tue, Oct 13, 2020 at 01:03:13PM -0500, Dan Murphy wrote: > On 10/9/20 7:12 AM, Dan Murphy wrote: > > Fix the issue when 'i' is equal to array size then array index over > > runs the array when checking for the watch dog value. > >=20 > > This also fixes the uninitialized wd_reg_val if the for..loop was not > > successful in finding an appropriate match. >=20 > Might want to pull this into next as well this is a 0-day bug fix Yes, merged now. I did not take it directly, since I had to rebase it first. Please always send power-supply patches based on the for-next branch, which already contained a fix for the uninitialized wd_reg_val. (also no need to Cc DT people for this patch :)) -- Sebastian --kitil4vbe2z42uf6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl+GHroACgkQ2O7X88g7 +poGPg/9FmY39emByDrWFBKDPkT2LQISCw8Uw0buqcEFvi6KWjzFwVGE/EdlaIeu 0eDp1/B34sYIAVfSdaDK8J7a57UpHC8c3ReuEz2TcJxbNSjyWy9V1O9OzVfYCfvA e31m7t2VdB7sjArMBkxgGdvjIkWsaDZKhIhImb5Zw9OOcSmuVBPO6w6x5SkY+hKb PPTZfbZspPdYYshVjQQGDRttU+FjPsoNqrxBq+2sT1Q1r+orKM6Hf+0iB5mgNleE 28P1bFcdSaYgsSSskaVxSJvG15uGHHvkbi634WOdfnH6QcTvOEcqgPu7l5FhxAd8 365QdowHxbII7p3ViknriVAMbm+hHkVSlqR/R4HffND8o6fhUCdgsp9gQb7epcsQ 7rN7z5vwH/URsF6hu3Aej/6FQ6kSVTIFTmoIv/C92v9xtt2DOtgOv/68rZeVNUpC tZMJjjGJOFT5JmLeYvtsG9YxCsAdCbBTuOmTaufMhL1DVA+3Uj/ft/2li0FKRgfX JfyRD/d+pQDzfjf2CEJnPtKfMQffOnW3xf0Ki87Zh+ouBWiirTC1S4Bf6dyFoGld sl8dKHXOXmVYDNJMRBye4c2RDcXE1GcuCctOVbQEm7+7qNE/nKWWT0F/QaiMvYKM RimhDvoMPA0mLCfWW5cTH3/4fAD7hp983e2mFkdZyD1O0SWrzc4= =MQmv -----END PGP SIGNATURE----- --kitil4vbe2z42uf6--