Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp263372pxu; Wed, 14 Oct 2020 00:06:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0iE8RgN/892kBZbB4bG9hcmMeUuUyz9fFBCkOE1HuYRdfgxzslTVRItBYqLbjpaiRwMjh X-Received: by 2002:a17:906:4ece:: with SMTP id i14mr3816557ejv.366.1602659165229; Wed, 14 Oct 2020 00:06:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602659165; cv=none; d=google.com; s=arc-20160816; b=eXm9ux6HD5RhRKc8VnL68t65I6tAfuTi5y0+5vN8n7IQ+qeeCOCuVQ2nYOzjM4llWQ jK/ulZ3iirBqkGrxmn9JdwmybitChyczJBFgSpsbgluikLHzM46oXuoBg6K+oNOdaSfa Q/dklMMsOY09BVkRrl+62UhzUQUpWDMjewe4kxevaLQkcKoB/c0pDvFdcBAVqxUxWilc QkDmcUyKHroYEEGHwSUx0XBXusOqmlV58kwZYDcPvIyuag8CAQQppRVZTcn2wePYe9tl RI6M77LZwVPr1zW3f3mSC3ovjQnnqtrwdw4B4kv+q+7hJDzoB/ZGaGzFnDklGLpVjjsz e8oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=b8+BtDvdnvqRGyviSgmSRydVjoh1Tbhgum73s6i2O4w=; b=hRjKnE0Z3jgnAkxmDLYnhp/3S+iHOd4gjmhpo8cg/nKqx97MUvLnfBKaLtkHgBgHw2 SSShkZCM0sqK82TidYqw7gWDTRxXuDPquPoumTaSTibF5jRlT/k0+ppFExuxErsD03xR AZgGnc4E0EYjmV1MHZFugI5P3EcZWM232plq8XclYFjLF+rM4fbPo3sBJ0P8XacYGlsI lFhkohBVUP20ok2dnOZP36O36/Uw5K9FfmzzyznGbBGgcYJGj318DbXYE2HDo0qBN+vu QzCaHgKUn13frV6Pnyx3GMtfs2BAcj6Lj5S/s4W7T27m2LO8+vPqG6MXcp6uA1s0nRaA lHIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Pkup2Mgd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p14si1450965eju.470.2020.10.14.00.05.42; Wed, 14 Oct 2020 00:06:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Pkup2Mgd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728864AbgJMWnR (ORCPT + 99 others); Tue, 13 Oct 2020 18:43:17 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:34260 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbgJMWnQ (ORCPT ); Tue, 13 Oct 2020 18:43:16 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09DMYZ2p023515; Tue, 13 Oct 2020 22:43:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=b8+BtDvdnvqRGyviSgmSRydVjoh1Tbhgum73s6i2O4w=; b=Pkup2MgdBgYdCnXqmsz62KHr+rDNs9izL61DuP2BZq1zUMfK9emXI7iGYY5x32MPJQYW hG/N4gmMmgvelE4dYKIXzKNBTP0Y1DMXXKk6lFAnDHJ2gPz+jacknAShI6s7+03Z30z6 O4GBb0KB/EYYqOp72AP6HnS07QgWchLlJ3zFBGqWyE7GBr6UDpWsAuJV2U2Zci7h2fed G9a7Az2RzMQ3VGxDih9RQn4YbOQVr2gMJbFsMchExZg9qTaEVcsotK1waqHj9VL0IIO/ +t0JP7mGodm42XgbqhyBkz/qUm1clsbUchYtBuT6rf6gC+Fe3AUYl1yu9hY8mm+6bh3W Sg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 3434wkmr7d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 13 Oct 2020 22:43:12 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09DMZWWa162453; Tue, 13 Oct 2020 22:43:11 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 344by2v0b6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Oct 2020 22:43:11 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 09DMhAIN002550; Tue, 13 Oct 2020 22:43:10 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 13 Oct 2020 15:43:10 -0700 From: "Martin K. Petersen" To: Arun Easi , Daniel Wagner , Nilesh Javali Cc: "Martin K . Petersen" , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] qla2xxx: Do not consume srb greedily Date: Tue, 13 Oct 2020 18:42:47 -0400 Message-Id: <160262862432.3018.12930536900869421478.b4-ty@oracle.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929073802.18770-1-dwagner@suse.de> References: <20200929073802.18770-1-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9773 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=965 spamscore=0 suspectscore=0 mlxscore=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010130158 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9773 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0 impostorscore=0 clxscore=1015 spamscore=0 priorityscore=1501 bulkscore=0 adultscore=0 mlxlogscore=982 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010130158 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2020 09:38:02 +0200, Daniel Wagner wrote: > qla2xx_process_get_sp_from_handle() will clear the slot which the > current srb is stored. So this function has a side effect. Therefore, > we can't use it in qla24xx_process_mbx_iocb_response() to check > for consistency and later again in qla24xx_mbx_iocb_entry(). > > Let's move the consistency check directly into > qla24xx_mbx_iocb_entry() and avoid the double call or any open coding > of the qla2xx_process_get_sp_from_handle() functionality. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: qla2xxx: Do not consume srb greedily https://git.kernel.org/mkp/scsi/c/657ed8a8a61b -- Martin K. Petersen Oracle Linux Engineering