Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp263500pxu; Wed, 14 Oct 2020 00:06:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQM6WK/gqHghocbr1hIfyzCduBugf//CAoRl7yTDklQO0Ek2V9Y2SwpVgTbqFB+Oj8kY3J X-Received: by 2002:a17:906:ae82:: with SMTP id md2mr3728828ejb.538.1602659184344; Wed, 14 Oct 2020 00:06:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602659184; cv=none; d=google.com; s=arc-20160816; b=R6Nc1UpWux+mVwyeg5LMSBhmQQjRV2wjkC0yRgRGR8NCr1UdInpN7ozDS55J2kF9R/ Fsz0O9GECxol3vzk+sYMFOnC2GxHlEg6ybBXe8HDiBnwsHlvt1y0Cpl4ipKk3iWWxnRM V4lGU+BQZT9/FhFTgojTwbR0qu0UR/WkjYNZGly8Z2WkDBKqM1AZfS8pv6u0vhCvrwwA CHN0eDbsAgJTsEqWt0HhzpMF4NVi085Oa97qHtWk913TfXEFbjry+GabRNqtxzWTikW5 KkOtw+S2UR61N9HICrAekqjkhgHOQJ+J9c6VyMncXSOEZBzPxn67pnjDsdEm6Gr+0ykZ CUtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TFlRI5MNpsaiIVg+BXhzUzXGZGooOPAo9AUn2HTcu/k=; b=1IVrYNYNTaNcRJno+J6Z5qL7iKKrjZZPX9cbqzDgS/a1fdtCoDR1UxeFyKN/f1+akd VRIoHal77o7KyrU6rwJS+Czyo2BTnN8bzW2pqXtDHSCM7ajKqQdvusBgq/+tfRre1rbg Y6GhjU8GnoI7Y95VWhshjibmSPdPrZhsnXAxIAbATa12gXJRxcPM/jGSjNcKNu4kpGZS 5zF7IuEI8dN7u8+aEqYzjUlrCR4edaNMB/rpoEJ+pq48nASRnwPNcxpvCI85QIX0Heu7 BCGhpHLHQu8DqeTcM/S2v+awgRlGBF/qNh/BaaD6B07pbJLO07ZAWvu3lZLFC+TKlB+F 6igg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b="tgJP/A3m"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si1764390ejf.271.2020.10.14.00.06.02; Wed, 14 Oct 2020 00:06:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b="tgJP/A3m"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728908AbgJMWnW (ORCPT + 99 others); Tue, 13 Oct 2020 18:43:22 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:46806 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbgJMWnU (ORCPT ); Tue, 13 Oct 2020 18:43:20 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09DMYVZJ143624; Tue, 13 Oct 2020 22:43:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=TFlRI5MNpsaiIVg+BXhzUzXGZGooOPAo9AUn2HTcu/k=; b=tgJP/A3mmSbMW14AMUMEWQnEfIvstm4yiFihDUdWgmxCKTemf0CuaNy10qxPrLDpBmvm Fz+bashN0OcECBxs04anOfA2I6nb+Qw5jSapAKD+M4dYHhn2nX6P6N/S7T7UXe3pMHLw IlZe0WwIid4PHmeJw/v/DQVaP8o0GjwORpwjS4TDsLr7mqIR1z1L9dSJgZDIsSr95eeR mA5wyUSTWSN1n7kBJxljGwiw7FLmC3aLK8zqe6cAA1O/wnECee22uzZlQIakzYPkx4ri VT2DFVc4OqUh/gszKi3FbpTp0U6iWEvl6eU4CXwXnb84j7QWBobNKvfsLlDlOuW882Wx Ww== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 343pajucqr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 13 Oct 2020 22:43:11 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09DMaWCb049038; Tue, 13 Oct 2020 22:43:10 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 343pvx1smd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Oct 2020 22:43:10 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 09DMh8St009844; Tue, 13 Oct 2020 22:43:08 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 13 Oct 2020 15:43:07 -0700 From: "Martin K. Petersen" To: Nilesh Javali , Colin King , Pavel Machek , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Himanshu Madhani , GR-QLogic-Storage-Upstream@marvell.com Cc: "Martin K . Petersen" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] scsi: qla2xxx: fix return of uninitialized value in rval Date: Tue, 13 Oct 2020 18:42:45 -0400 Message-Id: <160262862435.3018.1712796250437801581.b4-ty@oracle.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201008183239.200358-1-colin.king@canonical.com> References: <20201008183239.200358-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9773 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010130158 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9773 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010130158 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Oct 2020 19:32:39 +0100, Colin King wrote: > A previous change removed the initialization of rval and there is > now an error where an uninitialized rval is being returned on an > error return path. Fix this by returning -ENODEV. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: qla2xxx: Fix return of uninitialized value in rval https://git.kernel.org/mkp/scsi/c/1ef16a407f54 -- Martin K. Petersen Oracle Linux Engineering