Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp290268pxu; Wed, 14 Oct 2020 01:04:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxl9AUYgJCIJUpHPVLghZUuh/8F3jvm64aNC9Y6Jd8QuVSpRqreghAtnnrFVmc0y7PFoEu/ X-Received: by 2002:a17:906:cd14:: with SMTP id oz20mr4044370ejb.7.1602662653268; Wed, 14 Oct 2020 01:04:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1602662653; cv=pass; d=google.com; s=arc-20160816; b=kvKdf/C/7uU8+ILLqBkj/OIl7MXIB9NfR0CG5DUmn5Q9Q8gPUThPWTCAvLGHE+HDxR MC6sVKFAK5bZu9YwJbGWMDGeP+ACuRu6fNQpiM7U5AURQ87jM4xUunX70sKxfTeUjgxS dBS5HdGbH0d1IxXN5sbnfhpfHVKIcQgZoSK7jroQAqoS+LizJZslARZuaGW3bWcNPNML aZDmrhK2N4ldOoDSYE2dSw6mi+PkxNjLozE1C266vHE/5fQh9aKxv23bg7IOsofWWDkV SX3qWKTdc0xsbIgQIGn1L4KwyqUhc6YBR7JF/ZSHLSEFzwZ+9MbsQMvyfxbxqEMrAIfQ ioeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :wdcipoutbound:content-language:accept-language:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature:ironport-sdr:dkim-signature; bh=0/TlRSoHxD0jOB+fYQJXpprbQfix0bHH0qvUSQO+MIw=; b=terYen+mpvomtNNYiqQHCAsb4kFsdBmDHVhY584ui2ayTxTdN/qbNjVx0nssiTQsLw ezkR0Iy9ENH3kork5Z3s8EHRfJFiZtcg4DBAafFFAdaMLcPyZy+MA/Pno8KP8GuWpijF uEBckX1m8ukPaPG/GRf6/lOUdtgqwa45x++mZFuAzLzHYGYOJ5V85DGXqg2J2V3ffHVE Ddhs4f1HvTjmCZu/G16lLU001PIF4IovV2+N3V9AP7WuARO1O37Nv4kcgnm5ypVw6Zj4 n5vqwmhR+cqWE5gAAd3zYw1hXCz/LbMpv/TX7fBoZyMHebeyWrUjfBXcRkCBAqfa19s3 J5Eg== ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=PcptP2l4; dkim=pass header.i=@sharedspace.onmicrosoft.com header.s=selector2-sharedspace-onmicrosoft-com header.b=dYxiKUxA; arc=pass (i=1 spf=pass spfdomain=wdc.com dkim=pass dkdomain=wdc.com dmarc=pass fromdomain=wdc.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=wdc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y20si1625247ejw.696.2020.10.14.01.03.49; Wed, 14 Oct 2020 01:04:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=PcptP2l4; dkim=pass header.i=@sharedspace.onmicrosoft.com header.s=selector2-sharedspace-onmicrosoft-com header.b=dYxiKUxA; arc=pass (i=1 spf=pass spfdomain=wdc.com dkim=pass dkdomain=wdc.com dmarc=pass fromdomain=wdc.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=wdc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729051AbgJNAUI (ORCPT + 99 others); Tue, 13 Oct 2020 20:20:08 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:56949 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727122AbgJNAUH (ORCPT ); Tue, 13 Oct 2020 20:20:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1602634808; x=1634170808; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=0/TlRSoHxD0jOB+fYQJXpprbQfix0bHH0qvUSQO+MIw=; b=PcptP2l4K94cf7gcxHkxeJEiWCMITls40aY+hUF2EMBjFOJSOZ/suaQb r/3sGx3GfSju7yOFjBDAzCmNFEXdepl1IgpYEbRv1z0CARDm12dBFQXj4 aj/iBIQ0Yhi/WTrrgR1+pbbe5+FCWbyIrIxj8Eif75omfPyHoWHWBuFYq cj1LO3US4LjtiJPG1E6O1Qls5awOI/jdiSU7Z1Zh5m+yMpaaiKW1DtEL1 UpVDdGOdHe3UrKxe99kUnNcBAHUUJjaQcJuCFShC+fBV+4H1JgBxaA346 1oeeJUr9r1VIXOlZ1FrvWmjnnUU7KkWCkdUKU4kuuyVoBRaWfJXFtYqfd g==; IronPort-SDR: mV5o+lH2b6VkQqULtJX2aVmj5EBIupPBkF5oFxd5l6szLbJGBJzAiIdCGWHEwaGo04+KhKpFm9 8IfIiT/OOWQj6rL71SlPVA7QSJ1MEhURdDpSv01iXi5rb7VRSlDNNUz/FxqFDTPY8SYQ7z9z2N NgCWL8m1ZQKMYvRvkkaPyTd+7JfFbotOJFuE4RZUPzdw+0BUKtEotye0GQ/5OvAy2QEmVln443 4Kck21xE90BztmLCqFvM4cWbFtuWX5oV94XzgWbMrOQlBOUpx7Xnbbi/QDSmLmFXxazStSMplQ BLk= X-IronPort-AV: E=Sophos;i="5.77,372,1596470400"; d="scan'208";a="149838186" Received: from mail-bn7nam10lp2109.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.109]) by ob1.hgst.iphmx.com with ESMTP; 14 Oct 2020 08:20:06 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CWyYC9capuROyWJvF0mk8J5bl8INmCtUkquUhcUCltNzo+Oqu4a/XnfRl8kndVjPAH5o/Fzl1uAyxIPDyoVIZf1xbC9bxzINHpt80PEmfwFLD6a6E2anuc2DDkXng866C+cyTZYSPoUIVNFw6s5mN2dBTOn5xZTG/lHZKa+RWCa/8vtJrmATzcE8+CtQk6FECiEd5Ow6BKNvEbcylFV9db80yiWxQoOk7f16uc2H8WVPPrjFY8kYoB+4qubQuBiJg1khbNTrMKvC/c5EBZxJCEimSFprfJTqC2S/EIVKYfU5T/UZYycb1uQ1we9uvcbm9U11QKA+o+Y/RLhLvUWGOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0/TlRSoHxD0jOB+fYQJXpprbQfix0bHH0qvUSQO+MIw=; b=boUmY712tY+RvQQsuX+7klTPgMVS3Yxoh5ucPGV4oP4Jh6GUrBEm41uqrpS1L0qLOV+QYyidpnePD5BksDHNKY3GuoGkfv6uy1B0oLjE5eRjo5p0Cb2Y8LJbVNpohNIjklJmtV0mvE4Tzal5oNl5LZ4pp5r+2rGuJP0tBo32Uf0qzaP8Obt9nus5WssgWXC+07lLHKB2i7nK3V0OunB3eRkTVhfLRg63zZI5MaVxg0ZytoqqybGt0aJZE3SGyLgHCE2T/swHfr/Ao0mmVMkL+EuN4VhgMOVB28JpRjuHNH7KCHK2DpV9SnBBwQ4/n03dtw6Y6K0Fr9RNdfVMmwkFZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0/TlRSoHxD0jOB+fYQJXpprbQfix0bHH0qvUSQO+MIw=; b=dYxiKUxAbPxZBvcnJOikewiqnusclB6UHtEpDYD90x+YESyKsP0Abn/JSJtK7HSNlQgr1r3Z1+o/3K72mJDXTVkXarqEhFPO9+O6BVPWNCOQJ/JmB841BPc1H2BixM7tWff1nk8q2iC0E8rpi83y7O2LX8JEy5d/6ORviVDgiao= Received: from BYAPR04MB4965.namprd04.prod.outlook.com (2603:10b6:a03:4d::25) by BYAPR04MB6024.namprd04.prod.outlook.com (2603:10b6:a03:e8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Wed, 14 Oct 2020 00:20:02 +0000 Received: from BYAPR04MB4965.namprd04.prod.outlook.com ([fe80::99ae:ab95:7c27:99e4]) by BYAPR04MB4965.namprd04.prod.outlook.com ([fe80::99ae:ab95:7c27:99e4%7]) with mapi id 15.20.3455.030; Wed, 14 Oct 2020 00:20:02 +0000 From: Chaitanya Kulkarni To: Kai-Heng Feng , "kbusch@kernel.org" , "axboe@fb.com" , "hch@lst.de" , "sagi@grimberg.me" CC: open list , "open list:NVM EXPRESS DRIVER" Subject: Re: [PATCH] nvme-pci: Disable Write Zeroes on Sandisk Skyhawk Thread-Topic: [PATCH] nvme-pci: Disable Write Zeroes on Sandisk Skyhawk Thread-Index: AQHWoT1BT5ZuzRm0u0uwFORdyBuENg== Date: Wed, 14 Oct 2020 00:20:02 +0000 Message-ID: References: <20200723155731.22313-1-kai.heng.feng@canonical.com> <20201013083445.12317-1-kai.heng.feng@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [199.255.45.62] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 22f9bd12-9b72-418d-c9fa-08d86fd6e50a x-ms-traffictypediagnostic: BYAPR04MB6024: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:96; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fbodv/hsRSI5ymY1IwN6xExvErv5p8sV/zaYh7fIaoSOuiXci7A5C6UcuKHEtNtSNMmsSl6HYpM6kIdLJ+HgZOhtlho2iudSkesqcIVAg8leAcDzlPEsmCU1vqnZA/gLZRx4Feg/LbJXaa9pSIGwD1b9bCOM6E0WFcMut9nHasEH5l12k/d2U0oAqjiYfU4gXQvPimAslE9R2MLKVV4pFgHiQWwbjkyhy25qRqq2mKPA3Wc1SfC97C+lXFVP6HMlCLJdNPbXvd+LoPzOaZ6XwdBhUX8PuC+zQCaADHMa1kx1JgdzdJRlm7o08dD4WVbRgTtyoSiOGM1XOrdzmsHWpsX6yH12Ajw7acEFiM2uqbloZn/bUcGKL7i1CiokL9wyXqpLHOOZp9Ww/3w84DyREQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR04MB4965.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(136003)(376002)(39860400002)(346002)(8676002)(8936002)(966005)(478600001)(83080400001)(83380400001)(53546011)(6506007)(7696005)(33656002)(55016002)(186003)(64756008)(26005)(52536014)(66476007)(5660300002)(76116006)(9686003)(66946007)(66446008)(66556008)(71200400001)(86362001)(4744005)(4326008)(2906002)(316002)(54906003)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: d6r5OXmd7g465sa7I/wG3SFiNerQcdj0UScNnmBNrT7tWmqIdIKGmVkmDl/ICprtGS0lJwlA613gUmcRaM9jzNddBKi8sk7xY5q2xaxPc60qjienNT4e4OAtAvgwf/lWIGYn1P7dfhSW8M6HgRuEcF8WZhYGDDNd4Jj6UJs8ZYqwEqsDRG7+XK+EkdUnW/qb8K27RfvP6LYtCnbdPYRBm2eQX8DM7EHnKwVQw+YSYcj7+V7mjz2hD/Bh1zOXye8mrbMsDBVHEC0WMHVrGKA8RosyrwTkLgBSVaINy+2ShrfrmtFTAenxu03fsy60Z5ZYy7dp0E5a64DrnEel0zV0AazxobrDKKemlV+vu6cGKg3+yI+N+1kW4y/HSx44LHCmJ1ZbomPB5rGmJHBgEr996wkZRb9Ig7fCcorOt7+aNOivL8JcJFYSO8mRUTaTJl+/nGgRm/xKjs2Rr4vagZLbc3B7VDxLcGOuWkUeVHoyErjIC97hoEG/1B2m4VFZuYnOJvHPtW6YJKmej2/zl6BsxmR3EKAOAF51IX0ezIkCKF6JL12SMxtw2pgwh5CKZIsjLYMG+1CSyyBZ+1lukgk53bCH9qN7jBIokpJcd8z6/rA1xteDhE7f6iByGw/EVPffCsEPk0zOcBTOK2k2exOJNQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR04MB4965.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22f9bd12-9b72-418d-c9fa-08d86fd6e50a X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2020 00:20:02.7500 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8a61CjurbI8f0wCPziW9G63FSU2ogNJKlGz2XsEJbga6/ZXlGlYyMD5SfD84sN8EH1q66Lfl01d36Og3dbX3eWsqB345vbQ6PTMHXnqLNc0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB6024 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/20 01:45, Kai-Heng Feng wrote:=0A= > Like commit 5611ec2b9814 ("nvme-pci: prevent SK hynix PC400 from using=0A= > Write Zeroes command"), Sandisk Skyhawk has the same issue:=0A= > [ 6305.633887] blk_update_request: operation not supported error, dev nvm= e0n1, sector 340812032 op 0x9:(WRITE_ZEROES) flags 0x0 phys_seg 0 prio clas= s 0=0A= >=0A= > So also disable Write Zeroes command on Sandisk Skyhawk.=0A= >=0A= > BugLink: https://bugs.launchpad.net/bugs/1899503=0A= > Signed-off-by: Kai-Heng Feng =0A= =0A= Are you sure this happens all the devices of the same model=0A= =0A= and not a firmware bug on specific device ?=0A= =0A= If yes then looks good.=0A= =0A= Reviewed-by: Chaitanya Kulkarni =0A= =0A= =0A= =0A=