Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: collinsd=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 59140C433C9
Subject: Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"
To:     Stephen Boyd <sboyd@kernel.org>, Mark Brown <broonie@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1600812258-17722-1-git-send-email-collinsd@codeaurora.org>
 <160151084091.310579.3876905878885019200@swboyd.mtv.corp.google.com>
 <20201001174326.GT6715@sirena.org.uk>
 <160157827040.310579.12112194764912078296@swboyd.mtv.corp.google.com>
 <7c45b147-f1d2-4b32-9e51-71c5d2cb576f@codeaurora.org>
 <20201002160324.GE5527@sirena.org.uk>
 <160166091282.310579.8553391053258607173@swboyd.mtv.corp.google.com>
 <20201002180430.GG5527@sirena.org.uk>
 <160167477566.310579.12040108464021349450@swboyd.mtv.corp.google.com>
From:   David Collins <collinsd@codeaurora.org>
Message-ID: <79326f1b-cd0a-50c2-db11-8b5a0f711cd3@codeaurora.org>
Date:   Tue, 13 Oct 2020 17:59:44 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <160167477566.310579.12040108464021349450@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/2/20 2:39 PM, Stephen Boyd wrote:
> I see things like this on my console:
> 
> [    1.684617] spmi spmi-0: PMIC arbiter version v5 (0x50000000)
> 
> and 'spmi' is the bus name I'm thinking about. But I think that's
> because there isn't a driver attached. Nothing prints for the 0-00
> device by default, so I enabled the debug print for it and I see
> 
> [    1.693280] pmic-spmi 0-00: 28: unknown v2.0
> 
> Anyway, the device name was written to follow i2c as far as I can tell.
> 
> If scripts, i.e. computers, have a hard time figuring out the name of
> the device then fix the script?

I agree that we can drop this patch.  There is no technical requirement
for the spmi device naming scheme to be changed.  We will update our
downstream test scripts to use the upstream naming scheme and also
socialize the naming difference internally.

Take care,
David

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project