Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: mdtipton=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0B607C433CB
Subject: Re: [PATCH] interconnect: qcom: sdm845: Enable keepalive for the MM1
 BCM
To:     Georgi Djakov <georgi.djakov@linaro.org>, linux-pm@vger.kernel.org
Cc:     okukatla@codeaurora.org, sibis@codeaurora.org,
        bjorn.andersson@linaro.org, amit.pundir@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201012194034.26944-1-georgi.djakov@linaro.org>
From:   Mike Tipton <mdtipton@codeaurora.org>
Message-ID: <56dc5ac7-2bed-4dbb-b7fc-c0308a2a454a@codeaurora.org>
Date:   Tue, 13 Oct 2020 18:10:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <20201012194034.26944-1-georgi.djakov@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/12/2020 12:40 PM, Georgi Djakov wrote:
> After enabling interconect scaling for display on the db845c board,
s/interconect/interconnect/

> in certain configurations the board hangs, while the following errors
> are observed on the console:
> 
>    Error sending AMC RPMH requests (-110)
>    qcom_rpmh TCS Busy, retrying RPMH message send: addr=0x50000
>    qcom_rpmh TCS Busy, retrying RPMH message send: addr=0x50000
>    qcom_rpmh TCS Busy, retrying RPMH message send: addr=0x50000
>    ...
> 
> In this specific case, the above is related to one of the sequencers
> being stuck, while client drivers are returning from probe and trying
> to disable the currently unused clock and interconnect resources.
> Generally we want to keep the multimedia NoC enabled like the rest of
> the NoCs, so let's set the keepalive flag on it too.
> 
> Fixes: aae57773fbe0 ("interconnect: qcom: sdm845: Split qnodes into their respective NoCs")
> Reported-by: Amit Pundir <amit.pundir@linaro.org>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
>   drivers/interconnect/qcom/sdm845.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Mike Tipton <mdtipton@codeaurora.org>