Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161475AbWHJRZS (ORCPT ); Thu, 10 Aug 2006 13:25:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161481AbWHJRZS (ORCPT ); Thu, 10 Aug 2006 13:25:18 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:44944 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S1161475AbWHJRZQ (ORCPT ); Thu, 10 Aug 2006 13:25:16 -0400 Date: Thu, 10 Aug 2006 19:24:40 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: Andrew Morton cc: John Stoffel , Jeff Garzik , cmm@us.ibm.com, linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/9] sector_t format string In-Reply-To: <20060810095413.3797b4a2.akpm@osdl.org> Message-ID: References: <1155172843.3161.81.camel@localhost.localdomain> <20060809234019.c8a730e3.akpm@osdl.org> <44DB203A.6050901@garzik.org> <44DB25C1.1020807@garzik.org> <44DB27A3.1040606@garzik.org> <44DB3151.8050904@garzik.org> <17627.23974.848640.278643@stoffel.org> <20060810095413.3797b4a2.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1165 Lines: 36 Hi, On Thu, 10 Aug 2006, Andrew Morton wrote: > For ext3 on x86: > > CONFIG_LBD=y: > > box:/usr/src/25> size fs/jbd/jbd.o fs/ext3/ext3.o > text data bss dec hex filename > 51076 8 32 51116 c7ac fs/jbd/jbd.o > 87466 1020 4 88490 159aa fs/ext3/ext3.o > > CONFIG_LBD=n: > > box:/usr/src/25> size fs/jbd/jbd.o fs/ext3/ext3.o > text data bss dec hex filename > 51133 8 32 51173 c7e5 fs/jbd/jbd.o > 87679 1020 4 88703 15a7f fs/ext3/ext3.o > > That's a grand total of 270 bytes of text saved. aka 0.19%. > > We'll save four bytes in the inode (unlikely to save anything due to slab > packing). sector_t is used in multiple structures (bio/request/buffer_head), which quickly adds up. ext3 is also currently not a very heavy sector_t user, if you try this with block/ you get a more than 3% difference. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/