Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp309424pxu; Wed, 14 Oct 2020 01:43:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhX7hzWAU0ReHbUYVsTXILImX/J0Grn19CXrbCSlrqtJGE0VZDVmf6A4X8c2kH9PmdDLsT X-Received: by 2002:a17:906:b043:: with SMTP id bj3mr4036736ejb.543.1602665029580; Wed, 14 Oct 2020 01:43:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602665029; cv=none; d=google.com; s=arc-20160816; b=Si4vPhtZ2OuvOLbp0dF9woyaBMFIq5h9eUtYsAWlLLSrNHjTYiCslqZe16+tGvVrR1 8f/mehXRcAUhHhMGWkdmQm/hZmILY/X0aAsoOgEYWa7rEEIW8tQMWaTzq4NacRFRwKoq XqDUF/3rO3c4LreJZEBcmWMM+85yfOOyGw1aZZQihFkx4XsTkmAfc/mi/itOJuO4J56+ MOWC2vg+ORYG/nWLqyApNVp/rrM1noWtvDeTPHnAiwzVfn0SjwUwX3fwSg+s1O4VmOOA YWKSDaWLi45EjOzsaE0xEoUH7VBdM5MeZtwLlcuK16URhwwWqUv3z3fYQd+zZPynwCnF 1F9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=nRETCMUggNgSzB3Ff8f9czD714/ySw0c2TVlidnZhzo=; b=A6YFFc54tOsNOcMTZvcyqITIGbrAx41J97dHk/HfCoDoriorDR6phl9Yh+34MTQ1kL fMeJv8AkDnculQ0CQpvJ78BFYR3JKF8LYJ+hEipsj8h8h4M/0J1U5268xi8fDhCZtA7m n4Z8DxaXNHV+5d6JuSkMxmu5LIuTYKBADRATiZz5zShIJhMKv/rSIKMraKQooxWPlNQ3 TEkn4m5ebFFbdXthUAQsb/nJ/h/WBC61gSKSusbA8Ftvh/4w6E/3bns1Q4HZMO8MY6wo LM1/VNxxBhTZvGeWdH139kHNOT3wSFobNSavS9fm9aCYRrjLFXJXJjwf6X03Ey2WRQCs v69w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d12si2068194ejj.237.2020.10.14.01.43.26; Wed, 14 Oct 2020 01:43:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727942AbgJNGRi (ORCPT + 99 others); Wed, 14 Oct 2020 02:17:38 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:37811 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725983AbgJNGRi (ORCPT ); Wed, 14 Oct 2020 02:17:38 -0400 Received: by mail-ed1-f67.google.com with SMTP id o18so1908331edq.4; Tue, 13 Oct 2020 23:17:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nRETCMUggNgSzB3Ff8f9czD714/ySw0c2TVlidnZhzo=; b=PQxKHD1LXYcFmio8bFpN2Z8nNuYPV26V1vnBECcgj5mKGcYAGQcPIzqKgDvFcNNBbT ey9FogTyaCuN/c8Nn7gF/hdQk09ELuimknijLpHVaPTmB1HprkF/6VXOQvuyr5v8xsa3 1Dwh4M0HQlyFCi9Qy3Thv4GTTitFI2ovrl3BlT49OL60G74h1Ec5gtxhwZeZiQIPvSwT xWdT1dpDHgLWksfBGEDxg9Onw4zXZpuR83LopJyQESVFCqbkQ5U5JFXRX5ijjt9vwWXb nk/tMYEvJM2sJbQU5VyxeOa9wKfU+z/TNZVUZJ4E/0YI5LzGjcICIa36G6wcXN1X7hHP qeZA== X-Gm-Message-State: AOAM533cULYFQ0e7Jk2YZL1eb+LtnK0GqItzgDojnLephULB9pfHQ0cA 7lYPZQib79ZsqdV9YKROE6qgcGLG9zA= X-Received: by 2002:a05:6402:651:: with SMTP id u17mr3419101edx.206.1602656255808; Tue, 13 Oct 2020 23:17:35 -0700 (PDT) Received: from kozik-lap ([194.230.155.240]) by smtp.googlemail.com with ESMTPSA id si13sm1047455ejb.49.2020.10.13.23.17.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Oct 2020 23:17:34 -0700 (PDT) Date: Wed, 14 Oct 2020 08:17:32 +0200 From: Krzysztof Kozlowski To: Stephen Boyd Cc: Chanwoo Choi , Kukjin Kim , Michael Turquette , Sylwester Nawrocki , Tomasz Figa , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Marek Szyprowski Subject: Re: [PATCH 2/2] clk: samsung: exynos-clkout: convert to module driver Message-ID: <20201014061732.GA3672@kozik-lap> References: <20201001165646.32279-1-krzk@kernel.org> <20201001165646.32279-3-krzk@kernel.org> <160264342071.310579.16332243912081691987@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <160264342071.310579.16332243912081691987@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2020 at 07:43:40PM -0700, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-10-01 09:56:46) > > diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c > > index 34ccb1d23bc3..68af082d4716 100644 > > --- a/drivers/clk/samsung/clk-exynos-clkout.c > > +++ b/drivers/clk/samsung/clk-exynos-clkout.c > > @@ -28,41 +31,103 @@ struct exynos_clkout { > [...] > > + if (!match) { > > + dev_err(dev, "cannot match parent device\n"); > > + return -EINVAL; > > + } > > + variant = match->data; > > + > > + *mux_mask = variant->mux_mask; > > + dev_err(dev, "MATCH: %x\n", variant->mux_mask); > > Is this a debug print? Debugging left over, thanks for catching this. I'll remove it. Best regards, Krzysztof