Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201014062740.78977-1-warthog618@gmail.com>
In-Reply-To: <20201014062740.78977-1-warthog618@gmail.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Wed, 14 Oct 2020 09:59:30 +0200
Message-ID: <CAMpxmJWkUc-ZnDj56Q7_1ba73RXFFHos3MYas2TZSe-Q2AwhPQ@mail.gmail.com>
Subject: Re: [PATCH 0/3] gpiolib: cdev: allow edge event timestamps to be
 configured as REALTIME
To:     Kent Gibson <warthog618@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Oct 14, 2020 at 8:28 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> This patch set adds the option to select CLOCK_REALTIME as the source
> clock for line events.
>
> The first patch is the core of the change, while the remaining two update
> the GPIO tools to make use of the new option.
>
> Kent Gibson (3):
>   gpiolib: cdev: allow edge event timestamps to be configured as
>     REALTIME
>   tools: gpio: add support for reporting realtime event clock to lsgpio
>   tools: gpio: add option to report wall-clock time to gpio-event-mon
>
>  drivers/gpio/gpiolib-cdev.c | 21 ++++++++++++++++++---
>  drivers/gpio/gpiolib.h      |  1 +
>  include/uapi/linux/gpio.h   | 12 +++++++++---
>  tools/gpio/gpio-event-mon.c |  6 +++++-
>  tools/gpio/lsgpio.c         |  4 ++++
>  5 files changed, 37 insertions(+), 7 deletions(-)
>
> --
> 2.28.0
>

The entire series looks good to me.

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Linus: do you think this can still make it into v5.10 as an
improvement to the new uAPI or do we have to wait until the next merge
window? Will you send another PR in this cycle?

Bartosz