Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: mdtipton=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E6FCFC433FE
Subject: Re: [PATCH] interconnect: qcom: Simplify the vcd compare function
To:     Georgi Djakov <georgi.djakov@linaro.org>, linux-pm@vger.kernel.org
Cc:     okukatla@codeaurora.org, sibis@codeaurora.org,
        bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org
References: <20201013171923.7351-1-georgi.djakov@linaro.org>
From:   Mike Tipton <mdtipton@codeaurora.org>
Message-ID: <2e9385a0-56ea-0a2f-6389-7530c34a5364@codeaurora.org>
Date:   Tue, 13 Oct 2020 18:39:54 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <20201013171923.7351-1-georgi.djakov@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/13/2020 10:19 AM, Georgi Djakov wrote:
> Let's simplify the cmp_vcd() function and replace the conditionals
> with just a single statement, which also improves readability.
> 
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
>   drivers/interconnect/qcom/bcm-voter.c | 15 ++++-----------
>   1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/interconnect/qcom/bcm-voter.c b/drivers/interconnect/qcom/bcm-voter.c
> index 887d13721e52..1cc565bce2f4 100644
> --- a/drivers/interconnect/qcom/bcm-voter.c
> +++ b/drivers/interconnect/qcom/bcm-voter.c
> @@ -41,17 +41,10 @@ struct bcm_voter {
>   
>   static int cmp_vcd(void *priv, struct list_head *a, struct list_head *b)
>   {
> -	const struct qcom_icc_bcm *bcm_a =
> -			list_entry(a, struct qcom_icc_bcm, list);
> -	const struct qcom_icc_bcm *bcm_b =
> -			list_entry(b, struct qcom_icc_bcm, list);
> -
> -	if (bcm_a->aux_data.vcd < bcm_b->aux_data.vcd)
> -		return -1;
> -	else if (bcm_a->aux_data.vcd == bcm_b->aux_data.vcd)
> -		return 0;
> -	else
> -		return 1;
> +	const struct qcom_icc_bcm *bcm_a = list_entry(a, struct qcom_icc_bcm, list);
> +	const struct qcom_icc_bcm *bcm_b = list_entry(b, struct qcom_icc_bcm, list);
> +
> +	return bcm_a->aux_data.vcd - bcm_b->aux_data.vcd;
>   }
>   
>   static u64 bcm_div(u64 num, u32 base)
> 

Reviewed-by: Mike Tipton <mdtipton@codeaurora.org>