Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp419984pxu; Wed, 14 Oct 2020 04:58:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyey2vKUmHPRR0DsviSE2824+XSd9gEmFkVe3pQJS8iv4cF1fsE0TZ88AVHHVXzQVNrlod1 X-Received: by 2002:a17:906:26ce:: with SMTP id u14mr4800518ejc.78.1602676698534; Wed, 14 Oct 2020 04:58:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602676698; cv=none; d=google.com; s=arc-20160816; b=PxS2txG3uY4ERXY8U+AJ/tqYoPuGDG4mZyszgiUedOKkFh09M8jtlVF5srbBwY0ao6 /kM/w169K+h0fNaVRLxQnzup5p2sEEMyokL1nY9t6acKn5dThmiuUqMuyBM5Sg7aXqx4 2P86Ws2SFr76oky17eA0mJ0tX8OPdvwKQrwoPf5QQ8Doo8yEi8Yncs0KAmO0DLwV8GgU 3spAUWvKFP+SSDV7hUJicwgLPV0j1Eo3PctXFtlsQIiClrG/5kpcMOmozrZK65U172Uz 7AdEdq8o91TiiqDcdv5pbuAZs8SAuNa+fljSPMc+MIAiBtqp5hGeiF2m5Hsu1M8dAZ2o UKOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=EKQgleS0X90DVJpSDecC+giPdCh+T5pBAVG7aaq6pgk=; b=A651WLwcWvYIkD3zwof+mNsXIe1G9znloAHhll63t9iVHItIQjF/0gxAqRSx93gcvw jk48AXK8tIRhTYSfrn8m00ndMsEYzJZPWHIzoq6HYzvM4/WnP0aG54PuBZ1ddHFi9e3G 2RcTs7nZUGOMXI4xSbE2y8z5fnGe+d2Bw+0vLh12GTQSlJ93PVdJX6O+RlTlN92v76me s/kXo2w3OZVqvNX2rxPKU31fmSzaz4GZ14STK70qUq6NxR0tM+iMLvZc+3dMLNwnXUJB Z8ljxc81v+86/emgWnJpu88BtGl5JmujY5/nInZH1dX8RXX+9GAkGwprxaHqi9Zihh96 5t2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BFTsU0wd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ss23si1917038ejb.654.2020.10.14.04.57.55; Wed, 14 Oct 2020 04:58:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BFTsU0wd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727310AbgJNCyl (ORCPT + 99 others); Tue, 13 Oct 2020 22:54:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:41010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbgJNCyk (ORCPT ); Tue, 13 Oct 2020 22:54:40 -0400 Received: from kernel.org (unknown [104.132.1.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F12621775; Wed, 14 Oct 2020 02:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602644080; bh=EKQgleS0X90DVJpSDecC+giPdCh+T5pBAVG7aaq6pgk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=BFTsU0wdA4s4b5IOJyKoyCQEcSKqquTRqJ8FP8vUzBGFuMHcnaPeaGr0pAj6Okn0s KiFpGbn7LJlyua+zZjiv+sJd5/cazdHTxocB5wYZtqKPsw2C09qiNV7gLfA4qkffAX fANrHVmksA1HBlILEGFr/gPuur55+nrYcReeilvk= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200921034522.9077-1-vulab@iscas.ac.cn> References: <20200921034522.9077-1-vulab@iscas.ac.cn> Subject: Re: [PATCH] clk: clk-prima2: fix return value check in prima2_clk_init() From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Xu Wang To: Xu Wang , baohua@kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mturquette@baylibre.com Date: Tue, 13 Oct 2020 19:54:39 -0700 Message-ID: <160264407937.310579.8734202361386358321@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Xu Wang (2020-09-20 20:45:22) > In case of error, the function clk_register() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). >=20 > Signed-off-by: Xu Wang > --- Applied to clk-next