Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp421014pxu; Wed, 14 Oct 2020 05:00:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyo9kYs6Z70woBaaAPadULtUyduOfQQK+y/fP27kMyV6q9jO0o8d+I6iseNqNkKULBKMl6U X-Received: by 2002:a17:906:4695:: with SMTP id a21mr4750922ejr.357.1602676808685; Wed, 14 Oct 2020 05:00:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602676808; cv=none; d=google.com; s=arc-20160816; b=egByEaxeWGw0oUgHVbhfYCWPVVpAlL50rmhRQz1drY/DJxU36DrJucWWuhzNZxkm3N ZatkX4BtQhaPcmtLQbdH2OkMwb5fQzoAdjXi8xyReWmbtRmvc1W9AvO/w+At/hdLHr13 G2OjlXXVIh+uAZszIXbIzKHZaS4mX5G1arVTeayztzCULvBtvVW5G7a0cfmXB/nBfpwb IYZKu7lOlX689J34A/GFI7AHqiAEPBO9XIBWtEuL/T1c1rRbmX6Ao3xQmUcBxcOYg/11 qwzJd2+uBfBi3MnnRFp7/nrb7I5I9CRvKseU/qqZvJ9I9jfs6tJ+goqYd/idKC4shxcc RAjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=Ofd+aGE1NVD/YhbGmQ3EePx3dlv3GLwuTc4d5Hn0XPA=; b=oURp90wqPavEHq9rnG9Ge+3WuiemljQClAb/i7PtmmBCe1Yp2mjtV80hbZVi3h4D4C +7r0pzPCmPvXDc7hHGENSeqVlPmJvFBONNQbOMnukIMQNX8fO5D5hatsrjGgA2Lshah3 NbpZyYpMAVY3K4NJevlZwolre68cNFkuhwqFDgpP/by8vLfV5eRjhobe4RDcjtkRS2KQ 5HkGA0jH5cid1/MpDU6CjvAMPvsYfyzuJvcM99prHSuakfPZ5Y1SaDl8RwQLooTJJGZQ mGpTFpdyKCnloPghW2wo4hvUG3/mG3eV+R0byDb+jPXyekuri5OOOU1fr16qfeF1RBXk mXFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kuScnuYB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si2007572edm.105.2020.10.14.04.59.45; Wed, 14 Oct 2020 05:00:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kuScnuYB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727682AbgJNDCA (ORCPT + 99 others); Tue, 13 Oct 2020 23:02:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:42940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbgJNDCA (ORCPT ); Tue, 13 Oct 2020 23:02:00 -0400 Received: from kernel.org (unknown [104.132.1.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F014321775; Wed, 14 Oct 2020 03:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602644520; bh=Ofd+aGE1NVD/YhbGmQ3EePx3dlv3GLwuTc4d5Hn0XPA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=kuScnuYBsO0weMDkgEgsvEqSaIBYINfjnUyY2f3Idi1BXHVHqNefB8+snlwRwEA1Z JXvxjOTIT7MsvYnaysQ74vdiGIJQdWBaCWBjkOyzpgJQ+0T8jn2FCWF21NldBkliZR k/bGcHZJZ9QuTH7Cpl198CgMFk8y6l0Qo/0DUphQ= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200809231202.15811-1-navid.emamdoost@gmail.com> References: <20200809231202.15811-1-navid.emamdoost@gmail.com> Subject: Re: [PATCH] clk: bcm2835: add missing release if devm_clk_hw_register fails From: Stephen Boyd Cc: emamd001@umn.edu To: Eric Anholt , Florian Fainelli , Matthias Brugger , Michael Turquette , Nathan Chancellor , Navid Emamdoost , Nicolas Saenz Julienne , Ray Jui , Rikard Falkeborn , Scott Branden , Stefan Wahren , YueHaibing , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org Date: Tue, 13 Oct 2020 20:01:58 -0700 Message-ID: <160264451882.310579.17812805617556961510@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Navid Emamdoost (2020-08-09 16:11:58) > In the implementation of bcm2835_register_pll(), the allocated pll is > leaked if devm_clk_hw_register() fails to register hw. Release pll if > devm_clk_hw_register() fails. >=20 > Signed-off-by: Navid Emamdoost > --- Applied to clk-next