Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e8382da95dda4dffa06f81a05e92e5555a074bab.camel@perches.com>
Subject: Re: [PATCH 0/2] module: some refactoring in module_sig_check()
From:   Joe Perches <joe@perches.com>
To:     Sergey Shtylyov <s.shtylyov@omprussia.ru>,
        Jessica Yu <jeyu@kernel.org>, linux-kernel@vger.kernel.org
Date:   Wed, 14 Oct 2020 01:35:19 -0700
In-Reply-To: <e6fd4ba1-b431-afd8-1800-3a8f4b74f30e@omprussia.ru>
References: <789a4e5c-8efd-bb1c-86e2-eed8b2b7b0af@omprussia.ru>
         <3897a8ce5760affa304952c2d30c1266589407f2.camel@perches.com>
         <e6fd4ba1-b431-afd8-1800-3a8f4b74f30e@omprussia.ru>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2020-10-14 at 11:18 +0300, Sergey Shtylyov wrote:
> Hello!
> 
> On 14.10.2020 1:44, Joe Perches wrote:
> 
> > > Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo.
> > > I'm doing some little refactoring in module_sig_check()...
> > > 
> > > [1/2] module: merge repetitive strings in module_sig_check()
> > > [2/2] module: unindent comments in module_sig_check()
> > 
> > I think this code is rather cryptic and could be made clearer.
> > 
> > How about:
> > ---
> >   kernel/module.c | 51 ++++++++++++++++++++++++++-------------------------
> >   1 file changed, 26 insertions(+), 25 deletions(-)
> 
>     Looks good. Do you want to post complete patch(es)? :-)

I don't like posting actual patches on top of other people.
It's a complete and compilable diff, it's just unsigned.

If you want a Signed-off-by: here's one:

Signed-off-by: Joe Perches <joe@perches.com>